Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigning the search bar #5121

Merged
merged 2 commits into from Mar 18, 2019
Merged

Conversation

divyabaid16
Copy link
Contributor

@divyabaid16 divyabaid16 commented Mar 17, 2019

Fixes #5090 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screenshot for the change:
Selection_073

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@plotsbot
Copy link
Collaborator

plotsbot commented Mar 17, 2019

1 Message
📖 @divyabaid16 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@CleverFool77
Copy link
Member

Great work @divyabaid16 🎉

@grvsachdeva
Copy link
Member

I tried your PR locally, but the width is smaller from the screenshot
Screenshot from 2019-03-17 18-41-46

@divyabaid16
Copy link
Contributor Author

@gauravano I have now changed the file and updated the screenshot.

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work @divyabaid16!

@jywarren jywarren merged commit e27121f into publiclab:master Mar 18, 2019
@jywarren
Copy link
Member

Yeah, really nice!

@divyabaid16 divyabaid16 deleted the redesign-search branch March 18, 2019 20:44
@CleverFool77
Copy link
Member

@divyabaid16 It's showing this in mine. Should I fix it ?
Screenshot from 2019-03-19 11-47-35

@divyabaid16
Copy link
Contributor Author

@CleverFool77 previously even in mine it was shown in that way. Then I had made some changes. Can you plz check it again?
Because I don't think there must be a problem.
Thanks!

@CleverFool77
Copy link
Member

CleverFool77 commented Mar 19, 2019

These were latest changes I fetched. I didn't check your pr locally rather I was syncing the master repo and my local repo. I'm working on other parts of same issue. So I came across this.. 🤔🤔.. I'll check it again though.

@divyabaid16
Copy link
Contributor Author

@CleverFool77
Oh!!! I now got the problem. In Mozilla Firefox it is working fine but in google chrome, this is the issue.
Can you please check it out one in Mozilla FireFox

Thank you so much for pointing out this!!

@CleverFool77
Copy link
Member

CleverFool77 commented Mar 19, 2019

Np @divyabaid16. If you've got no problem, then I can fix it.

@CleverFool77
Copy link
Member

I'll check it out in mozilla 👍

@divyabaid16 divyabaid16 mentioned this pull request Mar 19, 2019
5 tasks
@divyabaid16
Copy link
Contributor Author

This issue is now fixed in Google Chrome too!
Thank you so much @CleverFool77

@CleverFool77
Copy link
Member

Ahh I just fixed it locally too. 😅😅. I was thinking of making PR.
Great work though 👍

icarito pushed a commit to icarito/plots2 that referenced this pull request Apr 9, 2019
* Redesigning of the search bar

* Redesigning of the search bar
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* Redesigning of the search bar

* Redesigning of the search bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants