Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The search bar is inline with pagination #5082

Merged
merged 2 commits into from Mar 15, 2019
Merged

Conversation

divyabaid16
Copy link
Contributor

Fixes #5035 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • PR is descriptively titled 📑
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screenshot for the same
screenshot

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@plotsbot
Copy link
Collaborator

plotsbot commented Mar 15, 2019

1 Message
📖 @divyabaid16 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@CleverFool77
Copy link
Member

@divyabaid16 It's usually preferred to have one commit. :)

@grvsachdeva
Copy link
Member

@jywarren @ebarry @steviepubliclab when we see the whole page 👇 , it looks like this

tags_view

Do you like this?

@divyabaid16
Copy link
Contributor Author

Actually, I proposed the idea to basically decrease the size of the search bar. Its length was too large and the button was far away.

@grvsachdeva
Copy link
Member

Agree that the search bar looks cleaner now. Design issues requires 👍 from @publiclab/community-reps

@jywarren
Copy link
Member

jywarren commented Mar 15, 2019 via email

@divyabaid16
Copy link
Contributor Author

@jywarren I have made the changes.
Please find the screenshot for the same and suggest any further changes.
Selection_068

@jywarren
Copy link
Member

This looks super awesome. I'm going to merge it! Thank you so much!!! 👍 👍 🎉

@jywarren jywarren merged commit 6d10661 into publiclab:master Mar 15, 2019
@divyabaid16 divyabaid16 deleted the tags branch March 16, 2019 12:17
icarito pushed a commit to icarito/plots2 that referenced this pull request Apr 9, 2019
* Aligned search bar in the middle

* Size of search bar decreased
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* Aligned search bar in the middle

* Size of search bar decreased
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants