New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor line 216 in profile.html.erb #4391
refactor line 216 in profile.html.erb #4391
Conversation
Hi @publiclab/reviewer, my build is failing. Travis doesn't show why? |
Generated by 🚫 Danger |
Checks passed! 🎉 |
Current_profile_user can you explain where this function is implemented? |
So that I can verify that it is working properly.
Well done both of you.
Thanks all
…On Mon, Dec 24, 2018, 10:05 PM Oorjit Chowdhary ***@***.*** wrote:
Checks passed! 🎉
@publiclab/reviewers <https://github.com/orgs/publiclab/teams/reviewers>
please review this one
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#4391 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUACQ8dQsiiPld6fbb8r3ySgKt4Xpx0Cks5u8QJLgaJpZM4ZgfnL>
.
|
Hi @SidharthBansal, I'm a little confused, sorry. Looks like @capedcrusader23 has implemented it in Application controller? Would I need to do this also? |
Just give me the link to the implementation
Thanks
…On Mon, Dec 24, 2018, 10:43 PM Dave Light ***@***.*** wrote:
Hi @SidharthBansal <https://github.com/SidharthBansal>, I'm a little
confused, sorry. Looks like @capedcrusader23
<https://github.com/capedcrusader23> has implemented it in Application
controller? Would I need to do this also?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4391 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUACQ52kSRkhY0E-0MMshrLeN7bTucoWks5u8QsugaJpZM4ZgfnL>
.
|
No need to implement.
On Mon, Dec 24, 2018, 10:47 PM Sidharth Bansal <
bansal.sidharth2996@gmail.com wrote:
… Just give me the link to the implementation
Thanks
On Mon, Dec 24, 2018, 10:43 PM Dave Light ***@***.*** wrote:
> Hi @SidharthBansal <https://github.com/SidharthBansal>, I'm a little
> confused, sorry. Looks like @capedcrusader23
> <https://github.com/capedcrusader23> has implemented it in Application
> controller? Would I need to do this also?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#4391 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AUACQ52kSRkhY0E-0MMshrLeN7bTucoWks5u8QsugaJpZM4ZgfnL>
> .
>
|
This looks good to me. |
Nice work @dave-light! We would love to have your help on other issues, if you are interested in solving more issues, you can find them at https://code.publiclab.org/#r=all |
Fixes #4342
rake test
@publiclab/reviewers
for help, in a comment below