Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor line 216 in profile.html.erb #4391

Merged

Conversation

dtlight
Copy link

@dtlight dtlight commented Dec 24, 2018

Fixes #4342

  • [✔️ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • [✔️ ] code is in uniquely-named feature branch and has no merge conflicts 📁
  • [✔️ ] PR is descriptively titled 📑
  • [✔️ ] ask @publiclab/reviewers for help, in a comment below

@dtlight
Copy link
Author

dtlight commented Dec 24, 2018

Hi @publiclab/reviewer, my build is failing. Travis doesn't show why?

@plotsbot
Copy link
Collaborator

1 Message
📖 @dave-light Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@oorjitchowdhary
Copy link
Member

Checks passed! 🎉
@publiclab/reviewers please review this one

@SidharthBansal
Copy link
Member

Current_profile_user can you explain where this function is implemented?

@SidharthBansal
Copy link
Member

SidharthBansal commented Dec 24, 2018 via email

@dtlight
Copy link
Author

dtlight commented Dec 24, 2018

Hi @SidharthBansal, I'm a little confused, sorry. Looks like @capedcrusader23 has implemented it in Application controller? Would I need to do this also?

@SidharthBansal
Copy link
Member

SidharthBansal commented Dec 24, 2018 via email

@SidharthBansal
Copy link
Member

SidharthBansal commented Dec 24, 2018 via email

@dtlight
Copy link
Author

dtlight commented Dec 24, 2018

@SidharthBansal
Copy link
Member

This looks good to me.
You can try out help wanted issues from the issue tracker.
Thanks

@SidharthBansal SidharthBansal merged commit 0594720 into publiclab:master Dec 24, 2018
@dtlight dtlight deleted the davelight_refactor_profile_html_erb branch December 24, 2018 18:28
@grvsachdeva
Copy link
Member

Nice work @dave-light! We would love to have your help on other issues, if you are interested in solving more issues, you can find them at https://code.publiclab.org/#r=all

@SidharthBansal SidharthBansal added this to the OAuth milestone Dec 26, 2018
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants