Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refactoring helper to application controller #4343

Merged
merged 2 commits into from Dec 21, 2018

Conversation

sashadev-sky
Copy link
Member

@sashadev-sky sashadev-sky commented Dec 19, 2018

Fixes #4339

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@ghost ghost assigned sashadev-sky Dec 19, 2018
@ghost ghost added the in progress label Dec 19, 2018
@plotsbot
Copy link
Collaborator

2 Messages
📖 @sashadev-sky Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@sashadev-sky
Copy link
Member Author

@gauravano

@grvsachdeva
Copy link
Member

Hey @sashadev-sky, sorry for the delay 😞 . Reviewing now!

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉 !

@grvsachdeva grvsachdeva merged commit 9152c43 into publiclab:master Dec 21, 2018
@ghost ghost removed the in progress label Dec 21, 2018
@sashadev-sky
Copy link
Member Author

@gauravano thank you for merging and updating the other two issues yesterday!

@grvsachdeva
Copy link
Member

I just did some editing. Thanks to you for opening issues 😄

@sashadev-sky sashadev-sky deleted the refactoring-users branch April 9, 2019 00:09
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* Add refactoring helper to application controller

* Remove explicit return statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants