Remove powertag in basic search

[jonxuxu]

Fixes #3482

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

I'm currently trying to solve the issue of powertags (example:tag) cluttering the results field. This pull request is work in progress at removing tags with ":" if the type parameter = "basic". First, I've applied @jywarren 's suggested changes.

However, while testing it seems that this doesn't fix the issue:

I would really appreciate any help from @publiclab/reviewers for pointers to start debugging plots2/app/controllers/tag_controller.rb .

[plotsbot]

	1 Warning
⚠️	It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!

	2 Messages
📖	@JonathanXu1 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[jywarren]

OK - i think we may need to add a test for this -- could we:

get :index, params: { basic: true }
assert_not assigns(:tags).include?('activity:____') # some tag from our fixtures which would show up in first page of results 

get :index, params: { basic: false }
assert assigns(:tags).include?('activity:____')

How does that sound? Thanks!

[ebarry]

It would be pretty exciting to see powertags removed in basic search, especially now that there's a great visualization already live on https://publiclab.org/stats/graph?limit=50, and continuing to be improved in #1502. How close is this test to completion @JonathanXu1 so we could add your work?

[SidharthBansal]

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab
@jywarren @gauravano