Added whenever gem for easily writing and deploying cron jobs

[namangupta01]

Added whenever gem for easily writing and deploying cron jobs
Sub-project part of Periodic Email Digests in #2104

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[PublicLabBot]

	1 Message
📖	@namangupta01 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

[SidharthBansal]

Looks good to me

[jywarren]

Awesome! @icarito ?

[icarito]

Hi!
Great to see this moving forward! I guess we need to include cron daemon in the production container.
The issue with that is that cron will live in the same container and thus when we redeploy the cron jobs will be lost. In addition to adding crond to Dockerfile I think we'll need to figure out when to run the whenever --update-crontab command.

[icarito]

I've added the cron daemon to our Docker definition - so the gem should work - but we still need to figure out when to run whenever --update-crontab.

[namangupta01]

We can run the command whenever we redeploy or push to main branch on server. Can't we?

…

On May 10, 2018 10:37 AM, "Sebastian Silva" ***@***.***> wrote: I've added the cron daemon to our Docker definition - so the gem should work - but we still need to figure out when to run whenever --update-crontab. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#2706 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATwCYanitUw1FMpSGIH6ZHL2hbrdWu7Gks5tw8r7gaJpZM4T4ueE> .

[icarito]

Yes! Thanks for clarifying when it needs to run.

…

On 10/05/18 02:54, Naman Gupta wrote: We can run the command whenever we redeploy or push to main branch on server. Can't we? On May 10, 2018 10:37 AM, "Sebastian Silva" ***@***.***> wrote: > I've added the cron daemon to our Docker definition - so the gem should > work - but we still need to figure out when to run whenever > --update-crontab. > > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub > <#2706 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ATwCYanitUw1FMpSGIH6ZHL2hbrdWu7Gks5tw8r7gaJpZM4T4ueE> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2706 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMMS63KtGOC-TNx45sOvJfW_v2HblxGks5tw_JKgaJpZM4T4ueE>.

[jywarren]

Should we test this by pushing it to unstable first? I mean, if it's not going to break anything, we can just merge it. But that's always an option. @namangupta01 what is the first time we'd actually see this thing start to run and how would we know? Can we, for example, have it do a cron job that puts a timestamp into a text file in a public folder like /public/time.txt so we can sort of confirm it's working in the staging server? (as a follow-up issue to this)?

[namangupta01]

yes we can have a cron job that put timestamp in the text file.

[namangupta01]

Should i add that example in this pr? I mean cron job. We will actually see this running once we implement reply by tweet and email digest.

[jywarren]

it's as you like; we could do a follow-up PR if you want to keep things simple. Would you add it in the code or in the description on GitHub?

…

On Thu, May 10, 2018 at 1:03 PM, Naman Gupta ***@***.***> wrote: Should i add that example in this pr? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#2706 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ1UyqjP9fhjkvb3G2vhIeuU7DYXNks5txHLigaJpZM4T4ueE> .

[namangupta01]

I will add a job into the config/schedule file using ruby code.

[namangupta01]

After this we could also do testing for whenever using this gem https://github.com/rafaelsales/whenever-test

[jywarren]

Oh cool! Well, tell me if you want me to merge this or hold off a bit, thank you!!!

…

On Thu, May 10, 2018 at 1:12 PM, Naman Gupta ***@***.***> wrote: After this we could also do testing for whenever using this gem https://github.com/rafaelsales/whenever-test — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#2706 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ99ioeJycdZH5uFtu16EmTAwRtdbks5txHURgaJpZM4T4ueE> .

[namangupta01]

I think we should merge this.. so that i can make a follow up pr for cron job discussed above based on this pr. Merging this pr won't affect anything as of now because there is currently no job. :)

[jywarren]

perfect!

…

On Thu, May 10, 2018 at 1:28 PM, Naman Gupta ***@***.***> wrote: I think we should merge this.. so that i can make a follow up pr for cron job discussed above based on this pr. Merging this pr won't affect anything as of now because there is currently no job. :) — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#2706 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ1U-aL2c_ssdTexHdLRP8Qo5YYuaks5txHjCgaJpZM4T4ueE> .