Added tooltip for banned users

[ViditChitkara]

fixes #1721

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

• all tests pass -- rake test:all
• code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
• pull request is descriptively named with #number reference back to original issue

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

[PublicLabBot]

	1 Message
📖	@ViditChitkara Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

[jywarren]

Whoa, awesome, @Diksha2008 how's this look to you?

[ViditChitkara]

Is there a need of adding an indicator to identify red colour, since one could easily identify a banned user by looking at the "action" column associated with that particular user. @jywarren , @Diksha2008 thoughts?

[jywarren]

Maybe @ebarry has a thought on this too?

…

On Wed, Oct 25, 2017 at 2:29 PM, Vidit ***@***.***> wrote: Is there a need of adding an indicator to identify red colour, since one could easily identify a banned user by looking at the "action" column associated with that particular user. @jywarren <https://github.com/jywarren> , @Diksha2008 <https://github.com/diksha2008> thoughts? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1726 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ9qx9vA7QBfeIUNWPeNVFjwpLMeiks5sv336gaJpZM4QGaXb> .

[Diksha2008]

This seems perfect! :)

[Diksha2008]

The action column won't show up for people other than admin or moderators so maybe an indicator as to what red indicates would be helpful for them!

[ebarry]

+1 looks great as far as i can tell!

[jywarren]

I think the red looks good -- and yes, maybe a message like:

Users marked in red have been banned!

And displaying this only for moderators and admins, otherwise it may be confusing for people who don't see any red marks :-)

[jywarren]

Which is to say - this looks fantastic. If you're interested in adding that one additional line, we'd love it too!

[ViditChitkara]

Sure @jywarren I'll make the changes right away!

[ViditChitkara]

@jywarren added it just under the heading "Recent Likes", would this be fine?

[jywarren]

Hi -- this looks perfect; merging now. If you're looking for a new challenge, please take a look at our help-wanted list: https://github.com/publiclab/plots2/labels/help-wanted

Thanks so much -- both to @ViditChitkara and to @Diksha2008 for making this issue! I hope we can keep working with you both!