Leaflet-blurred-location integration template initialized with object #1590
Conversation
|
Added the library to application.js and bower, also added the template to /locations/form. Here's a screenshot
|
Generated by 🚫 Danger |
app/views/locations/_form.html.erb
Outdated
|
|
||
| var blurredLocation = new BlurredLocation(options); | ||
|
|
||
| blurredLocation.panMapToGeocodedLocation("placenameInput"); |
There was a problem hiding this comment.
Then here we'd want to create a button and click listener so you can save the location and it runs addTag() -- which I believe takes just the tagname as a parameter. But you can look at @shelbyfire's recent pull requests to confirm that usage.
|
@jywarren Made the changes, please have a look. |
app/views/locations/_form.html.erb
Outdated
| @@ -47,6 +48,8 @@ | |||
|
|
|||
| <br /> | |||
| <input editable="false" id="placenameDisplay" type="text" class="form-control" /> | |||
| <br /> | |||
| <button class="btn btn-primary" onclick="addTag('location: blurred')">Save Location</button> | |||
There was a problem hiding this comment.
oops, no space here, should be just location:blurred and then we should also use 'lat:' + location.getLat() and 'lon:' + location.getLat() -- make sense? That way the button adds all three tags.
|
Ooh, is this ready to go? Thanks! |
|
Cool, this seems ready for testing out. Merging! |
|
It'll be testable at https://publiclab.org/locations/form -- probably later today! |
|
@publiclab/infrastructure @icarito - would you mind merging this to stable and getting it in the queue (along with other recent merges) for production today? Thanks! |
|
OK - @publiclab/infrastructure @icarito i've merged to stable, having happened to get to it first. Chat me in Riot if you need! |
|
Hi Jeff,
Thanks!
I'm going to make a mail filter to highlight messages with tag
@publiclab/infrastructure
<https://github.com/orgs/publiclab/teams/infrastructure> so that I can
catch them quicker.
Talk with you on Riot!
Regards,
Sebastian
…On 19/09/17 11:01, Jeffrey Warren wrote:
OK - @publiclab/infrastructure
<https://github.com/orgs/publiclab/teams/infrastructure> @icarito
<https://github.com/icarito> i've merged to stable, having happened to
get to it first. Chat me in Riot if you need!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1590 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMMS0muk_SE6kMY5Ph_z5Oqi_6Q_fDHks5sj-VhgaJpZM4PDZ0t>.
|
|
Roger that! :-) |
|
Hi, just a note that this has just been deployed to production! -- |
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
rake test:allPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.
Thanks!
#1416