Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard.html.erb : background properties changed in .dashboard .img fix for issue #11485 #11565

Merged
merged 1 commit into from Nov 17, 2022

Conversation

victoria-parker
Copy link
Contributor

background-size changed from cover to contain and background-repeat and background-position were added, at .dashboard .img from line 46 to 50 in app/views/dashboard_v2/dashboard.html.erb

Fixes #11485

#11485

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

background change in  .dashboard .img
@gitpod-io
Copy link

gitpod-io bot commented Nov 14, 2022

@codeclimate
Copy link

codeclimate bot commented Nov 14, 2022

Code Climate has analyzed commit d03e348 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/9295839122/artifacts/436091528

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #11565 (d03e348) into main (55dd755) will increase coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11565      +/-   ##
==========================================
+ Coverage   83.21%   83.33%   +0.12%     
==========================================
  Files          93       93              
  Lines        5772     5772              
==========================================
+ Hits         4803     4810       +7     
+ Misses        969      962       -7     
Impacted Files Coverage 螖
app/api/srch/search.rb 70.51% <0.00%> (+3.84%) 猬嗭笍
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) 猬嗭笍

@victoria-parker
Copy link
Contributor Author

Hello @TildaDares ! Here is my new PR.
Cheers!

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @victoria-parker. Thank you!

@TildaDares TildaDares merged commit 0889fcf into publiclab:main Nov 17, 2022
@welcome
Copy link

welcome bot commented Nov 17, 2022

Congrats on merging your first pull request! 馃檶馃帀鈿★笍
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 馃槂. Please find the link to our latest check-in here 馃摑
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 馃檶

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 馃槙

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 馃槃 馃帀

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 馃摜

@TildaDares
Copy link
Member

Congratulations on merging your PR @victoria-parker 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset background image to fit container
2 participants