New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dashboard.html.erb : background properties changed in .dashboard .img fix for issue #11485 #11565
Conversation
background change in .dashboard .img
Code Climate has analyzed commit d03e348 and detected 0 issues on this pull request. View more on Code Climate. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #11565 +/- ##
==========================================
+ Coverage 83.21% 83.33% +0.12%
==========================================
Files 93 93
Lines 5772 5772
==========================================
+ Hits 4803 4810 +7
+ Misses 969 962 -7
|
Hello @TildaDares ! Here is my new PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @victoria-parker. Thank you!
Congrats on merging your first pull request! 馃檶馃帀鈿★笍 Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 馃檶 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 馃槙 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 馃槃 馃帀 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our Gitter channel to connect with other contributors 馃摜 |
Congratulations on merging your PR @victoria-parker 馃帀 |
background-size changed from cover to contain and background-repeat and background-position were added, at .dashboard .img from line 46 to 50 in app/views/dashboard_v2/dashboard.html.erb
Fixes #11485
#11485
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below