Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset background image to fit container #11485: Update dashboard.css #11559

Closed

Conversation

victoria-parker
Copy link
Contributor

Hello! This is my first contribution. background-size changed from cover to contain, background-repeat:no-repeat; and background-position:center; added at .dashboard .dashboard-blog .img, from line 126 to 130

Fixes #11485 (#11485)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

background-size changed from cover to contain, background-repeat and background-position added at .dashboard .dashboard-blog .img, from line 126 to 130
@welcome
Copy link

welcome bot commented Nov 5, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Nov 5, 2022

@codeclimate
Copy link

codeclimate bot commented Nov 5, 2022

Code Climate has analyzed commit 19f0106 and detected 0 issues on this pull request.

View more on Code Climate.

@victoria-parker
Copy link
Contributor Author

Hello @publiclab/reviewers! Here is my first contribution, I wait for your review, thank you a lot!

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/9146947414/artifacts/425372529

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #11559 (19f0106) into main (54d7984) will increase coverage by 0.12%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11559      +/-   ##
==========================================
+ Coverage   83.21%   83.33%   +0.12%     
==========================================
  Files          93       93              
  Lines        5772     5772              
==========================================
+ Hits         4803     4810       +7     
+ Misses        969      962       -7     

see 2 files with indirect coverage changes

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victoria-parker
Copy link
Contributor Author

Hi @victoria-parker, can you add it to this style instead https://github.com/publiclab/plots2/blob/main/app/views/dashboard_v2/dashboard.html.erb#L46-L48?

Thanks!

Hello @TildaDares ! Yes sure!

Copy link

stale bot commented Dec 15, 2023

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label 🎉 . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! 💯 Thank you for your contributions! 🙌 🎈.

@stale stale bot added the stale label Dec 15, 2023
@stale stale bot closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset background image to fit container
2 participants