Update admin_controller.rb #11531

Ceejaycodez · 2022-10-21T22:49:07Z

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

welcome · 2022-10-21T22:49:09Z

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌

Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

gitpod-io · 2022-10-21T22:49:15Z

codeclimate · 2022-10-21T22:49:59Z

app/controllers/admin_controller.rb

@@ -15,7 +15,7 @@ def promote_admin
        flash[:error] = 'Only admins can promote other users to admins.'
      end
    end
-    redirect_to '/profile/' + @user.username + '?_=' + Time.now.to_i.to_s
+   redirect_to "/profile/#{@user.username}?_=#{Time.now.to_i}"


Possible unprotected redirect

codeclimate · 2022-10-21T22:49:59Z

app/controllers/admin_controller.rb

@@ -29,7 +29,7 @@
        flash[:error] = 'Only moderators can promote other users.'
      end
    end
-    redirect_to '/profile/' + @user.username + '?_=' + Time.now.to_i.to_s
+   redirect_to "/profile/#{@user.username}?_=#{Time.now.to_i}"


Possible unprotected redirect

codeclimate · 2022-10-21T22:49:59Z

app/controllers/admin_controller.rb

@@ -43,7 +43,7 @@
        flash[:error] = 'Only admins and moderators can demote other users.'
      end
    end
-    redirect_to '/profile/' + @user.username + '?_=' + Time.now.to_i.to_s
+    redirect_to "/profile/#{@user.username}?_=#{Time.now.to_i}"


Possible unprotected redirect

codeclimate · 2022-10-21T22:49:59Z

app/controllers/admin_controller.rb

@@ -280,7 +280,7 @@
    else
      flash[:error] = 'Only moderators can moderate other users.'
    end
-    redirect_to '/profile/' + user.name + '?_=' + Time.now.to_i.to_s
+   redirect_to "/profile/#{user.name}?_=#{Time.now.to_i}"


Possible unprotected redirect

codeclimate · 2022-10-21T22:50:00Z

app/controllers/admin_controller.rb

@@ -291,7 +291,7 @@
    else
      flash[:error] = 'Only moderators can unmoderate other users.'
    end
-    redirect_to '/profile/' + user.name + '?_=' + Time.now.to_i.to_s
+    redirect_to "/profile/#{user.name}?_=#{Time.now.to_i}"


Possible unprotected redirect

github-actions · 2022-10-21T22:59:49Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8904540216/artifacts/407566316

codecov · 2022-10-21T23:01:54Z

Codecov Report

Merging #11531 (b672567) into main (a5aecc3) will decrease coverage by 0.12%.
The diff coverage is 75.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11531      +/-   ##
==========================================
- Coverage   83.33%   83.21%   -0.13%     
==========================================
  Files          93       93              
  Lines        5772     5772              
==========================================
- Hits         4810     4803       -7     
- Misses        962      969       +7

Impacted Files	Coverage Δ
app/controllers/admin_controller.rb	`80.24% <75.00%> (ø)`
app/services/execute_search.rb	`88.88% <0.00%> (-5.56%)`	⬇️
app/api/srch/search.rb	`66.66% <0.00%> (-3.85%)`	⬇️

TildaDares

Hi @Ceejaycodez, feel free to click the Commit suggestion button. Thanks!

app/controllers/admin_controller.rb

Co-authored-by: Tilda Udufo <mathildaudufo@gmail.com>

codeclimate · 2022-10-22T12:40:54Z

app/controllers/admin_controller.rb

@@ -15,7 +15,7 @@ def promote_admin
        flash[:error] = 'Only admins can promote other users to admins.'
      end
    end
-    redirect_to '/profile/' + @user.username + '?_=' + Time.now.to_i.to_s
+    redirect_to "/profile/#{@user.username}?_=#{Time.now.to_i}"


Possible unprotected redirect

codeclimate · 2022-10-22T12:40:55Z

app/controllers/admin_controller.rb

@@ -29,7 +29,7 @@ def promote_moderator
        flash[:error] = 'Only moderators can promote other users.'
      end
    end
-    redirect_to '/profile/' + @user.username + '?_=' + Time.now.to_i.to_s
+    redirect_to "/profile/#{@user.username}?_=#{Time.now.to_i}"


Possible unprotected redirect

codeclimate · 2022-10-22T12:40:55Z

app/controllers/admin_controller.rb

@@ -280,7 +280,7 @@ def moderate
    else
      flash[:error] = 'Only moderators can moderate other users.'
    end
-    redirect_to '/profile/' + user.name + '?_=' + Time.now.to_i.to_s
+    redirect_to "/profile/#{user.name}?_=#{Time.now.to_i}"


Possible unprotected redirect

codeclimate · 2022-10-22T12:40:55Z

app/controllers/admin_controller.rb

@@ -301,7 +301,7 @@ def ban
    else
      flash[:error] = 'Only moderators can ban other users.'
    end
-    redirect_to '/profile/' + user.name + '?_=' + Time.now.to_i.to_s
+    redirect_to "/profile/#{user.name}?_=#{Time.now.to_i}"


Possible unprotected redirect

codeclimate · 2022-10-22T12:40:55Z

app/controllers/admin_controller.rb

@@ -312,7 +312,7 @@ def unban
    else
      flash[:error] = 'Only moderators can unban other users.'
    end
-    redirect_to '/profile/' + user.name + '?_=' + Time.now.to_i.to_s
+    redirect_to "/profile/#{user.name}?_=#{Time.now.to_i}"


Possible unprotected redirect

codeclimate · 2022-10-22T12:40:58Z

Code Climate has analyzed commit b672567 and detected 14 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	6
Security	8

Note: there are 8 critical issues.

View more on Code Climate.

github-actions · 2022-10-22T12:52:17Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8908976529/artifacts/407960561

TildaDares

Amazing work @Ceejaycodez. Thank you!

welcome · 2022-10-22T16:09:11Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 📥

TildaDares · 2022-10-22T16:09:24Z

Congratulations on merging your PR @Ceejaycodez 🎉

Update admin_controller.rb

7cbef6a

codeclimate bot reviewed Oct 21, 2022

View reviewed changes

Ceejaycodez mentioned this pull request Oct 21, 2022

Rubocop - Use string interpolation #11429

Closed

5 tasks

TildaDares requested changes Oct 22, 2022

View reviewed changes

TildaDares linked an issue Oct 22, 2022 that may be closed by this pull request

Rubocop - Use string interpolation #11429

Closed

5 tasks

Ceejaycodez and others added 6 commits October 22, 2022 13:38

Update app/controllers/admin_controller.rb

001944f

Co-authored-by: Tilda Udufo <mathildaudufo@gmail.com>

Update app/controllers/admin_controller.rb

59cdb31

Co-authored-by: Tilda Udufo <mathildaudufo@gmail.com>

Update app/controllers/admin_controller.rb

40c1c33

Co-authored-by: Tilda Udufo <mathildaudufo@gmail.com>

Update app/controllers/admin_controller.rb

3aef5a4

Co-authored-by: Tilda Udufo <mathildaudufo@gmail.com>

Update app/controllers/admin_controller.rb

00b757e

Co-authored-by: Tilda Udufo <mathildaudufo@gmail.com>

Update app/controllers/admin_controller.rb

b672567

Co-authored-by: Tilda Udufo <mathildaudufo@gmail.com>

codeclimate bot reviewed Oct 22, 2022

View reviewed changes

TildaDares approved these changes Oct 22, 2022

View reviewed changes

TildaDares merged commit a7f8199 into publiclab:main Oct 22, 2022

This was referenced Nov 10, 2022

Update admin_controller.rb #11440

Closed

update admin_controller.rb #11437

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update admin_controller.rb #11531

Update admin_controller.rb #11531

Ceejaycodez commented Oct 21, 2022 •

edited

welcome bot commented Oct 21, 2022

gitpod-io bot commented Oct 21, 2022

codeclimate bot Oct 21, 2022

codeclimate bot Oct 21, 2022

codeclimate bot Oct 21, 2022

codeclimate bot Oct 21, 2022

codeclimate bot Oct 21, 2022

github-actions bot commented Oct 21, 2022

codecov bot commented Oct 21, 2022 •

edited

TildaDares left a comment

codeclimate bot Oct 22, 2022

codeclimate bot Oct 22, 2022

codeclimate bot Oct 22, 2022

codeclimate bot Oct 22, 2022

codeclimate bot Oct 22, 2022

codeclimate bot commented Oct 22, 2022

github-actions bot commented Oct 22, 2022

TildaDares left a comment

welcome bot commented Oct 22, 2022

TildaDares commented Oct 22, 2022

Update admin_controller.rb #11531

Update admin_controller.rb #11531

Conversation

Ceejaycodez commented Oct 21, 2022 • edited

welcome bot commented Oct 21, 2022

gitpod-io bot commented Oct 21, 2022

codeclimate bot Oct 21, 2022

Choose a reason for hiding this comment

codeclimate bot Oct 21, 2022

Choose a reason for hiding this comment

codeclimate bot Oct 21, 2022

Choose a reason for hiding this comment

codeclimate bot Oct 21, 2022

Choose a reason for hiding this comment

codeclimate bot Oct 21, 2022

Choose a reason for hiding this comment

github-actions bot commented Oct 21, 2022

codecov bot commented Oct 21, 2022 • edited

Codecov Report

TildaDares left a comment

Choose a reason for hiding this comment

codeclimate bot Oct 22, 2022

Choose a reason for hiding this comment

codeclimate bot Oct 22, 2022

Choose a reason for hiding this comment

codeclimate bot Oct 22, 2022

Choose a reason for hiding this comment

codeclimate bot Oct 22, 2022

Choose a reason for hiding this comment

codeclimate bot Oct 22, 2022

Choose a reason for hiding this comment

codeclimate bot commented Oct 22, 2022

github-actions bot commented Oct 22, 2022

TildaDares left a comment

Choose a reason for hiding this comment

welcome bot commented Oct 22, 2022

TildaDares commented Oct 22, 2022

Ceejaycodez commented Oct 21, 2022 •

edited

codecov bot commented Oct 21, 2022 •

edited