Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update talk_controller.rb #11525

Merged
merged 1 commit into from Oct 21, 2022
Merged

Update talk_controller.rb #11525

merged 1 commit into from Oct 21, 2022

Conversation

Teslimsama
Copy link
Contributor

rubocop fixes: talk-controller #11497

  • made changes to a line of code which is below
  • "- @node = Node.find_by_path 'wiki/' + params[:id] if @node.nil?"
  • "+ @node = Node.find_by_path "wiki/#{params[:id]}" if @node.nil?"
  • @welcome
    Copy link

    welcome bot commented Oct 21, 2022

    Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
    Dangerbot will test out your code and reply in a bit with some pointers and requests.
    Also please refer here for installation help 💿
    There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


    One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


    Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

    @gitpod-io
    Copy link

    gitpod-io bot commented Oct 21, 2022

    @codeclimate
    Copy link

    codeclimate bot commented Oct 21, 2022

    Code Climate has analyzed commit b6282c5 and detected 0 issues on this pull request.

    View more on Code Climate.

    @Teslimsama
    Copy link
    Contributor Author

    @TildaDares @cesswairimu i am done is there anything else to do

    @github-actions
    Copy link

    This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
    https://github.com/publiclab/plots2/suites/8892954252/artifacts/406761592

    @codecov
    Copy link

    codecov bot commented Oct 21, 2022

    Codecov Report

    Merging #11525 (b6282c5) into main (83e0439) will increase coverage by 6.61%.
    The diff coverage is 100.00%.

    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##             main   #11525      +/-   ##
    ==========================================
    + Coverage   76.71%   83.33%   +6.61%     
    ==========================================
      Files          93       93              
      Lines        5772     5772              
    ==========================================
    + Hits         4428     4810     +382     
    + Misses       1344      962     -382     
    Impacted Files Coverage Δ
    app/controllers/talk_controller.rb 100.00% <100.00%> (ø)
    app/controllers/users_controller.rb 80.78% <0.00%> (+0.35%) ⬆️
    app/controllers/spam2_controller.rb 72.54% <0.00%> (+0.98%) ⬆️
    app/controllers/user_tags_controller.rb 83.78% <0.00%> (+1.35%) ⬆️
    app/controllers/admin_controller.rb 80.24% <0.00%> (+1.64%) ⬆️
    app/controllers/search_controller.rb 97.67% <0.00%> (+2.32%) ⬆️
    app/models/revision.rb 88.29% <0.00%> (+3.19%) ⬆️
    app/models/node_tag.rb 100.00% <0.00%> (+3.70%) ⬆️
    app/models/user.rb 86.23% <0.00%> (+4.34%) ⬆️
    app/models/user_tag.rb 100.00% <0.00%> (+4.34%) ⬆️
    ... and 15 more

    Copy link
    Member

    @TildaDares TildaDares left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Amazing work @Teslimsama. Thank you!!

    @TildaDares TildaDares merged commit 3496818 into publiclab:main Oct 21, 2022
    @welcome
    Copy link

    welcome bot commented Oct 21, 2022

    Congrats on merging your first pull request! 🙌🎉⚡️
    Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
    Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
    Now that you've completed this, you can help someone else take their first step!
    Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

    Help others take their first step

    Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

    https://code.publiclab.org

    Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

    People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

    Read about how to help support another newcomer here, or find other ways to offer mutual support here.

    You can also join our Gitter channel to connect with other contributors 📥

    @TildaDares
    Copy link
    Member

    Congratulations on merging your PR @Teslimsama 🎉🎉

    @TildaDares TildaDares mentioned this pull request Oct 21, 2022
    5 tasks
    @Teslimsama
    Copy link
    Contributor Author

    Thanks 🙏

    @Teslimsama
    Copy link
    Contributor Author

    @TildaDares will I be added to contributors

    @TildaDares
    Copy link
    Member

    Adding a commit automatically includes your name as a contributor @Teslimsama.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    2 participants