Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update batch_controller.rb #11521

Merged
merged 1 commit into from Oct 21, 2022
Merged

Conversation

IvyJeptoo
Copy link
Contributor

@IvyJeptoo IvyJeptoo commented Oct 20, 2022

Fixes #11492

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented Oct 20, 2022

@codeclimate
Copy link

codeclimate bot commented Oct 20, 2022

Code Climate has analyzed commit f7ea7cc and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8870472597/artifacts/405159521

@IvyJeptoo
Copy link
Contributor Author

Hello @cesswairimu I have made the changes please review.

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #11521 (7d5f74a) into main (ab30588) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 7d5f74a differs from pull request most recent head f7ea7cc. Consider uploading reports for the commit f7ea7cc to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11521      +/-   ##
==========================================
- Coverage   83.33%   83.21%   -0.13%     
==========================================
  Files          93       93              
  Lines        5772     5772              
==========================================
- Hits         4810     4803       -7     
- Misses        962      969       +7     
Impacted Files Coverage Δ
app/controllers/batch_controller.rb 90.19% <100.00%> (ø)
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.66% <0.00%> (-3.85%) ⬇️

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @IvyJeptoo. Thank you!!

@TildaDares TildaDares merged commit 91f5036 into publiclab:main Oct 21, 2022
@welcome
Copy link

welcome bot commented Oct 21, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 📥

@TildaDares
Copy link
Member

Congratulations on merging your PR @IvyJeptoo 🎉🎉

@IvyJeptoo
Copy link
Contributor Author

Thank you so much @TildaDares.
Are there other problems I could contribute to? I'd be glad to work on them.

@TildaDares
Copy link
Member

@IvyJeptoo You can look around the repo for other issues to work on or create issues for others to work on. Thank you!

@IvyJeptoo
Copy link
Contributor Author

@IvyJeptoo You can look around the repo for other issues to work on or create issues for others to work on. Thank you!

Yeah sure! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch-controller rubocop fixes
2 participants