rubocop fixes - csvfiles controller #11516

victory-lydia · 2022-10-19T14:05:26Z

Fixes #11493

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

gitpod-io · 2022-10-19T14:05:31Z

codecov · 2022-10-19T14:11:02Z

Codecov Report

Merging #11516 (c1ef238) into main (a5d2483) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11516   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files          93       93           
  Lines        5772     5772           
=======================================
  Hits         4810     4810           
  Misses        962      962

Impacted Files	Coverage Δ
app/controllers/csvfiles_controller.rb	`62.50% <ø> (ø)`
app/models/user.rb	`86.23% <0.00%> (-0.27%)`	⬇️
app/controllers/home_controller.rb	`95.58% <0.00%> (-0.07%)`	⬇️
app/controllers/spam2_controller.rb	`72.54% <0.00%> (+0.70%)`	⬆️

github-actions · 2022-10-19T14:15:15Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8855196888/artifacts/404035701

victory-lydia · 2022-10-19T14:16:02Z

@cesswairimu and @jywarren please can you review my pull request

github-actions · 2022-10-19T14:49:29Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8855196888/artifacts/404088683

7malikk · 2022-10-19T14:54:18Z

README.md

@@ -124,6 +124,7 @@ We recommend you either work in a virtual environment, or on a dual booted syste
 2. [Dual Booting](https://www.tecmint.com/install-ubuntu-alongside-with-windows-dual-boot/amp/), [option2](https://askubuntu.com/questions/1031993/how-to-install-ubuntu-18-04-alongside-windows-10), [video guide](https://www.youtube.com/watch?v=qNeJvujdB-0&fbclid=IwAR0APhs89jlNR_ENKbSwrp6TI6P-wxlx-a0My9XBvPNAfwtADZaAXqcKtP4)
 3. [Setting up a Linux virtual env](https://itsfoss.com/install-linux-in-virtualbox/)

+


Were you supposed to add this space in the readme?

I did not add any space in the readme

Here at line 127 it shows you added a line.

7malikk · 2022-10-19T14:58:29Z

@victory-lydia Hey there, aside from the comment I made, I noticed you were supposed to add an empty line based on #11493, I don't see that change being made.

Just my input

victory-lydia · 2022-10-19T15:13:50Z

@victory-lydia Hey there, aside from the comment I made, I noticed you were supposed to add an empty line based on #11493, I don't see that change being made.

Just my input
I did it in the last commit and got a error message

7malikk · 2022-10-19T15:24:56Z

@victory-lydia Hey there, aside from the comment I made, I noticed you were supposed to add an empty line based on #11493, I don't see that change being made.
Just my input
I did it in the last commit and got a error message

What was the error message?

victory-lydia · 2022-10-19T15:36:25Z

@victory-lydia Hey there, aside from the comment I made, I noticed you were supposed to add an empty line based on #11493, I don't see that change being made.
Just my input
I did it in the last commit and got a error message

What was the error message?

To remove the white space

7malikk · 2022-10-19T15:58:22Z

@victory-lydia Hey there, aside from the comment I made, I noticed you were supposed to add an empty line based on #11493, I don't see that change being made.
Just my input
I did it in the last commit and got a error message

What was the error message?

To remove the white space

Then you're good.
@jywarren @TildaDares first-timers bot created an FTO at #11493, when @victory-lydia implemented it she got an error to remove white space. I believe this is worth looking into.

TildaDares

@victory-lydia Those are the spaces the failing test is complaining about.

app/controllers/csvfiles_controller.rb

Co-authored-by: Tilda Udufo <mathildaudufo@gmail.com>

github-actions · 2022-10-20T08:29:24Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8870121069/artifacts/405136724

TildaDares

Amazing work @victory-lydia. Thank you!

codeclimate · 2022-10-20T13:18:13Z

Code Climate has analyzed commit c1ef238 and detected 0 issues on this pull request.

View more on Code Climate.

github-actions · 2022-10-20T13:29:17Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8875384075/artifacts/405492544

welcome · 2022-10-20T17:14:42Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 📥

TildaDares · 2022-10-20T17:15:01Z

Congratulations on merging your PR @victory-lydia 🎉

victory-lydia · 2022-10-20T21:31:57Z

Congratulations on merging your PR @victory-lydia 🎉

Thanks so much

victory-lydia added 2 commits October 18, 2022 23:18

I changed lines 10,31 and 41

7c1f546

Changed lines 10 and 31

c5231ee

7malikk reviewed Oct 19, 2022

View reviewed changes

TildaDares requested changes Oct 19, 2022

View reviewed changes

app/controllers/csvfiles_controller.rb Outdated Show resolved Hide resolved

app/controllers/csvfiles_controller.rb Outdated Show resolved Hide resolved

victory-lydia and others added 2 commits October 20, 2022 09:16

Update app/controllers/csvfiles_controller.rb

1b52500

Co-authored-by: Tilda Udufo <mathildaudufo@gmail.com>

Update app/controllers/csvfiles_controller.rb

cdc290a

Co-authored-by: Tilda Udufo <mathildaudufo@gmail.com>

Update README.md

c1ef238

TildaDares approved these changes Oct 20, 2022

View reviewed changes

TildaDares merged commit 83e0439 into publiclab:main Oct 20, 2022

TildaDares mentioned this pull request Oct 20, 2022

rubocop fixes - csvfiles controller #11493

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rubocop fixes - csvfiles controller #11516

rubocop fixes - csvfiles controller #11516

victory-lydia commented Oct 19, 2022 •

edited

gitpod-io bot commented Oct 19, 2022

codecov bot commented Oct 19, 2022 •

edited

github-actions bot commented Oct 19, 2022

victory-lydia commented Oct 19, 2022 •

edited

github-actions bot commented Oct 19, 2022

7malikk Oct 19, 2022

victory-lydia Oct 19, 2022

7malikk Oct 19, 2022

7malikk commented Oct 19, 2022

victory-lydia commented Oct 19, 2022

7malikk commented Oct 19, 2022

victory-lydia commented Oct 19, 2022

7malikk commented Oct 19, 2022

TildaDares left a comment

github-actions bot commented Oct 20, 2022

TildaDares left a comment

codeclimate bot commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

welcome bot commented Oct 20, 2022

TildaDares commented Oct 20, 2022

victory-lydia commented Oct 20, 2022

		@@ -124,6 +124,7 @@ We recommend you either work in a virtual environment, or on a dual booted syste
		2. [Dual Booting](https://www.tecmint.com/install-ubuntu-alongside-with-windows-dual-boot/amp/), [option2](https://askubuntu.com/questions/1031993/how-to-install-ubuntu-18-04-alongside-windows-10), [video guide](https://www.youtube.com/watch?v=qNeJvujdB-0&fbclid=IwAR0APhs89jlNR_ENKbSwrp6TI6P-wxlx-a0My9XBvPNAfwtADZaAXqcKtP4)
		3. [Setting up a Linux virtual env](https://itsfoss.com/install-linux-in-virtualbox/)

rubocop fixes - csvfiles controller #11516

rubocop fixes - csvfiles controller #11516

Conversation

victory-lydia commented Oct 19, 2022 • edited

gitpod-io bot commented Oct 19, 2022

codecov bot commented Oct 19, 2022 • edited

Codecov Report

github-actions bot commented Oct 19, 2022

victory-lydia commented Oct 19, 2022 • edited

github-actions bot commented Oct 19, 2022

7malikk Oct 19, 2022

Choose a reason for hiding this comment

victory-lydia Oct 19, 2022

Choose a reason for hiding this comment

7malikk Oct 19, 2022

Choose a reason for hiding this comment

7malikk commented Oct 19, 2022

victory-lydia commented Oct 19, 2022

7malikk commented Oct 19, 2022

victory-lydia commented Oct 19, 2022

7malikk commented Oct 19, 2022

TildaDares left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 20, 2022

TildaDares left a comment

Choose a reason for hiding this comment

codeclimate bot commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

welcome bot commented Oct 20, 2022

TildaDares commented Oct 20, 2022

victory-lydia commented Oct 20, 2022

victory-lydia commented Oct 19, 2022 •

edited

codecov bot commented Oct 19, 2022 •

edited

victory-lydia commented Oct 19, 2022 •

edited