Update spam2_controller.rb #11515
Update spam2_controller.rb #11515
Conversation
My FTO issue for Public Lab
|
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
|
|
|
@TildaDares Please can you review this? |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
@TildaDares I have made the changes, I don't know why a test failed, This is a screenshot of the error |
There was a problem hiding this comment.
Hi @JeffyDave, removing the extra plus sign should fix the error. Thank you!
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
app/controllers/spam2_controller.rb
Outdated
| when 'published' | ||
| @nodes.where(status: 1).order('changed DESC') | ||
| when 'published' | ||
| @nodes.where(status: 1).order('changed DESC') |
There was a problem hiding this comment.
Use 2 (not 1) spaces for indentation.
There was a problem hiding this comment.
I have made the necessary change.
|
Code Climate has analyzed commit 137c2ec and detected 0 issues on this pull request. View more on Code Climate. |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #11515 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 93 93
Lines 5772 5772
=======================================
Hits 4810 4810
Misses 962 962
|
|
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our Gitter channel to connect with other contributors 📥 |
|
Congratulations on merging your PR @JeffyDave 🎉🎉 |
|
Congratulations @JeffyDave 🍾🎊🎉 |
My FTO issue for Public Lab
I made changes to the issue to serve as my FTO
Fixes ##11498
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment below