Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes to #11499 issue #11510

Merged
merged 2 commits into from Oct 19, 2022
Merged

Make changes to #11499 issue #11510

merged 2 commits into from Oct 19, 2022

Conversation

Dorcas-BD
Copy link
Contributor

@Dorcas-BD Dorcas-BD commented Oct 18, 2022

Fixes #11499 #11503

@gitpod-io
Copy link

gitpod-io bot commented Oct 18, 2022

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #11510 (7b9e2a2) into main (a5d2483) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11510      +/-   ##
==========================================
- Coverage   83.33%   83.33%   -0.01%     
==========================================
  Files          93       93              
  Lines        5772     5771       -1     
==========================================
- Hits         4810     4809       -1     
  Misses        962      962              
Impacted Files Coverage Δ
app/controllers/home_controller.rb 95.58% <100.00%> (-0.07%) ⬇️

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8835310920/artifacts/402622526

@Dorcas-BD
Copy link
Contributor Author

Dorcas-BD commented Oct 18, 2022

Hello @cesswairimu, I have made the necessary changes. Please kindly review it.

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉 thanks

@cesswairimu cesswairimu merged commit b69d622 into publiclab:main Oct 19, 2022
@welcome
Copy link

welcome bot commented Oct 19, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 📥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rubocop fixes - home controller
2 participants