Update editor_controller.rb #11507
Update editor_controller.rb #11507
Conversation
Removed 'and', replaced the logic with double ampersand This PR closes publiclab#11502
|
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
|
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
app/controllers/editor_controller.rb
Outdated
| @@ -35,12 +35,12 @@ def rich | |||
| @main_image = Image.find_by(id: params[:main_image]).path | |||
| end | |||
|
|
|||
| if params[:tags]&.include? "lat:" and params[:tags]&.include? "lon:" | |||
| if params[:tags]&.include? "lat:" && params[:tags]&.include? "lon:" | |||
There was a problem hiding this comment.
unexpected token tSTRING
(Using Ruby 2.5 parser; configure using TargetRubyVersion parameter, under AllCops)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #11507 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 93 93
Lines 5772 5772
=======================================
Hits 4810 4810
Misses 962 962
|
|
@AlphaRomeoMike can I help you out with the tests? |
Yes please |
maybe you could send me a chat on the communication platform my username is briesta so that we can hop into a meet |
I dont think I will be able to because of my busy schedule |
How do you suggest I help you? |
Balaclava_Nerd#6566 on Discord |
Great, sent!(Ivy J) |
There was a problem hiding this comment.
Hi @AlphaRomeoMike, lat: and lon: need to be wrapped in parentheses. The same thing applies to the other lines. Thank you!
Co-authored-by: Tilda Udufo <mathildaudufo@gmail.com>
|
Code Climate has analyzed commit 6b0efce and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
Looking great, thanks all, merging now. @IvyJeptoo @AlphaRomeoMike would any of you like to open an issue and fix the code-climate warnings raised here? you can find the suggestions here https://codeclimate.com/github/publiclab/plots2/pull/11507, Its similar changes @TildaDares mentioned above. |
|
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our Gitter channel to connect with other contributors 📥 |
Removed 'and', replaced the logic with double ampersand
Fixes #11502 🎉🍾