Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #11379: Made the subtopics method #11380

Closed
wants to merge 12 commits into from
Closed

Fixes #11379: Made the subtopics method #11380

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
669acd0
Fixes #11379: Made the subtopics method
KarishmaVanwari Sep 2, 2022
d195a96
Update tag_controller_test.rb
jywarren Sep 2, 2022
31ba768
Apply suggestions from code review
jywarren Sep 2, 2022
9d73d03
fixing my syntax errors
jywarren Sep 2, 2022
3ab03cc
Merge branch 'main' of https://github.com/KarishmaVanwari/plots2 into…
KarishmaVanwari Sep 3, 2022
908f3ee
Merge branch 'subtopics' of https://github.com/KarishmaVanwari/plots2…
KarishmaVanwari Sep 3, 2022
e76687d
Update app/controllers/tag_controller.rb
KarishmaVanwari Sep 5, 2022
c7cc324
Merge branch 'main' of https://github.com/KarishmaVanwari/plots2 into…
KarishmaVanwari Sep 5, 2022
f4d90c8
small fixes
jywarren Sep 5, 2022
e220ca5
resolved
jywarren Sep 5, 2022
517175f
Merge branch 'subtopics' of https://github.com/KarishmaVanwari/plots2…
KarishmaVanwari Sep 6, 2022
11cdb1c
Created test data
KarishmaVanwari Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/fixtures/node_tags.yml
View file
Open in desktop
Expand Up @@ -284,3 +284,9 @@ sub_tag:
tid: 37
nid: 1
uid: 2

subtopic_tag:
tid: 38
uid: 2
nid: 41
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but it's applied to this page, which is a note, not a wiki:

https://github.com/KarishmaVanwari/plots2/blob/subtopics/test/fixtures/nodes.yml#L497

Will that affect the logic, and possibly cause it not to return things?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it should get the slug for this note, and try to use it as a subtopic tagname, according to this logic:

https://github.com/publiclab/plots2/pull/11380/files#diff-5d60373322d4baf080e5f3957fc30d0e8058337c202f5641e1775402776428b1R533

Aha - yes, so, then it takes the slug from that page, which is "jeff-12-20-2020-ouija-board" - and tries to find a tag with that name. It doesn't find one, so it returns null.

Let's change this to instead point at this node, which is a page, with slug about. Then let's add a new tag with the name about so that there is actually a tag that can be returned.

We could give these more realistic tag names so it makes more sense... but, maybe it's not worth it for now. Let's just get it working first.

Suggested change
nid: 41
nid: 2

So now you'll also have to add a new tags.yml entry, but it doesn't need a node_tags.yml entry, since we only look if the tag exists, not if we used it anywhere. Let's see how that works!

date: <%= DateTime.now.to_i %>
4 changes: 4 additions & 0 deletions test/fixtures/tags.yml
View file
Open in desktop
Expand Up @@ -150,3 +150,7 @@ hidden_response_tag:
subscribed_tag:
tid: 37
name: sub:tag

subtopic_tag:
tid: 38
name: parent:one