Convert map nodes to note nodes #11225
Conversation
|
|
|
Also, part of the bigger deprecation effort being tracked at #11185 (Added the comment so that MR shows up there too. This comment can be ignored) |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
| revision.body += map_details | ||
| revision.body += old_body | ||
| revision.body += notes | ||
| revision.body += cartographer_notes |
There was a problem hiding this comment.
Love this arrangement 鉂わ笍
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
Hi @anirudhprabhakaran3 i'll be offline for 2 days but let me or Tilda or Cess know when this needs another review or when it's ready! Thanks! |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
The migration is working succssfully on the unstable server! However, the build is not completing because of another error in the Uglifier gem, |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
Code Climate has analyzed commit 10010fb and detected 0 issues on this pull request. View more on Code Climate. |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
@anirudhprabhakaran3 can you check that this seems to be working OK on stable before we push it to production? Thanks! |
|
Hi! Yeah, I'll try to check that. On my local laptop, I used to just run If you have access to the console to stable, could you run that maybe once and get the count? Thank you! |
* remove map files post #11225 * routes * test removals * test tweaks * fix bob node * test fix * routes and test fixes * reworked map-style path routing, handling in notes_controller, cleanout map_controller * fix functional tests * routes order change * Update test/functional/notes_controller_test.rb * Update test/functional/notes_controller_test.rb
Fixes #4072
This MR aims to convert all map nodes into note nodes. It consists of a db migration, which can be run using
rails db:migrateto be run. The script does the following:notegenerate_pathMake sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowScreenshots
This is the console output before running the migration.
We can see that before the migration, it is being rendered as a map. We can see that from the URL as well.
After running the migration, we note that all the maps have been converted to notes:
It is also reflected when we go to the notes page:
Individually, we can see the map in the note template.