Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation method in list.html.erb #11213

Conversation

jenniferhalloran
Copy link
Contributor

@jenniferhalloran jenniferhalloran commented Jun 23, 2022

I have made the changes asked in app/voews/users/list.html.erb and added the translation method, but I had an issue trying to find the changes I needed to make in config/en.yml. Such file does not seem to exist, so I tried looking in config/locale/en.yml but I did not see the line of code that I should change.
If someone would like to guide me in the right direction I am happy to update this pull request!

Fixes #11205

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@jenniferhalloran jenniferhalloran requested a review from a team as a code owner June 23, 2022 00:28
@welcome
Copy link

welcome bot commented Jun 23, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Jun 23, 2022

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #11213 (2222f71) into main (5e44070) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 2222f71 differs from pull request most recent head 2515321. Consider uploading reports for the commit 2515321 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11213      +/-   ##
==========================================
- Coverage   82.45%   82.34%   -0.12%     
==========================================
  Files          98       98              
  Lines        5992     5992              
==========================================
- Hits         4941     4934       -7     
- Misses       1051     1058       +7     
Impacted Files Coverage Δ
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.66% <0.00%> (-3.85%) ⬇️

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/7052083921/artifacts/277856969

@TildaDares
Copy link
Member

I'm so sorry @jenniferhalloran, that was a mistake on my end. The correct link to the file is this https://github.com/publiclab/plots2/blob/main/config/locales/en.yml#L160. Sorry for the inconvenience!

@codeclimate
Copy link

codeclimate bot commented Jun 24, 2022

Code Climate has analyzed commit 2515321 and detected 0 issues on this pull request.

View more on Code Climate.

@jenniferhalloran
Copy link
Contributor Author

@TildaDares don't worry at all! I think I have updated the correct page now. :)

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/7081149288/artifacts/279733385

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jenniferhalloran. Thank you!!

@TildaDares TildaDares merged commit a4c7547 into publiclab:main Jun 24, 2022
@welcome
Copy link

welcome bot commented Jun 24, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 📥

@jenniferhalloran
Copy link
Contributor Author

Thank you @TildaDares! I am looking forward to learning more about open source coding with ya'll :)

@jenniferhalloran jenniferhalloran deleted the jenniferhalloran-add-translation-method branch July 13, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add translation method in list.html.erb
2 participants