Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐥: replace valid email address "moderators" instead of "organizers" #11192

Merged
merged 2 commits into from Jun 16, 2022

Conversation

htinz
Copy link
Contributor

@htinz htinz commented Jun 14, 2022

Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screenshot 2022-06-14 at 20 16 49

@gitpod-io
Copy link

gitpod-io bot commented Jun 14, 2022

@codeclimate
Copy link

codeclimate bot commented Jun 16, 2022

Code Climate has analyzed commit 0df8725 and detected 0 issues on this pull request.

View more on Code Climate.

@TildaDares
Copy link
Member

Hi @htinz, can you add a link to the issue? Thanks!

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the
format fixes #0000 (for example)

@TildaDares
Copy link
Member

I also like how expressive your PR titles are with those emojis😅

@htinz
Copy link
Contributor Author

htinz commented Jun 16, 2022

Hi @TildaDares,

Thank you for your lovely comment. 🤣

Hope, this is the original issues: #11189

@TildaDares TildaDares linked an issue Jun 16, 2022 that may be closed by this pull request
7 tasks
Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @htinz. Thank you!!

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6964941787/artifacts/272106297

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #11192 (0df8725) into main (833f7b1) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11192      +/-   ##
==========================================
+ Coverage   82.34%   82.45%   +0.11%     
==========================================
  Files          98       98              
  Lines        5992     5992              
==========================================
+ Hits         4934     4941       +7     
+ Misses       1058     1051       -7     
Impacted Files Coverage Δ
app/api/srch/search.rb 70.51% <0.00%> (+3.84%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

@TildaDares TildaDares merged commit c7de0ac into publiclab:main Jun 16, 2022
@welcome
Copy link

welcome bot commented Jun 16, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 📥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Spam Reporting Email Address
2 participants