Outreachy project planning #6887
Comments
|
I've been organizing a more list-style planning issue here, with lots of related issues linked in and grouped; i'll try to organize that today! #6801 |
|
I also wanted to point to this great resource on testing your work on the |
|
There are really a lot of different moving parts in this project, so please ask questions if you get lost or confused! Or see a way to do things that'd be better! For example, here's an instance of using LEL within plots2 that isn't working correctly: #6889 |
|
Ok great! One question I have: in my proposal I have a plan for a new way of setting location on users profiles. Do you still want me to do this, even though it's not on the plots2 checklists? |
|
Sure! I think we will all need to update/refine/revise project plans and I'd love to workshop a new design idea as part of it! Also, the listings I've added so far are by no means complete or comprehensive. I wanted to share this "how we work" issue which is a bit dense but could have some useful info for you both: #5667 |
|
OK, so @nstjean has identified a lot of great bugfixes and UI enhancements for location entry in Phase 1 - they all sound GREAT. Just be sure that the styling matches our style guide (esp the "Add a location" styling we've been trying to standardize - a white button with a red marker -- #6856) and the dashboard is about to be rebuilt #6787 but preserves a space for the Add your Location button there too. Let's start listing out those ideas/tasks in our checklist post at #6801 and we can mark them done as we go! @crisner has some awesome work planned for the layer selector/control/menu. I wonder if @crisner may want to prioritize the debugging of the search-for-location in the location selector (which uses this library: https://github.com/publiclab/leaflet-blurred-location) and the layers "browser" menu, based on the static HTML in publiclab/leaflet-environmental-layers#232. One feature we are really interested in is a demo in the Github Pages demo which can generate an embed code -- basically as you pan and zoom and select and deselect layers, it would modify the URL hash, and you'd be able to get the URL from that. Both using a method like The reason I suggest this is that the layers selector is already at the beginning of your timeline @crisner and this would nicely tie together a number of adjacent and parallel projects. As you use the new menu, it also allows you to then copy that to display on another website, you know? |
|
I also recommend that you each look through each others' proposals and think about how, as you get into the project, you might divide up the work for those middle sections which overlap most; for example, both of you have shared some really great UI mockups with ideas for where active layers might be displayed, and other elements. If we do a good job developing things in small modular pieces, we should be able to work in synchrony on these things. Finally, one area where we might expand, given that we have 2 people working on this project now, is in testing -- both in These features are complex and deeply intertwined. We may gain a lot in stability if we protect the features (and bugfixes) with good tests, so I'd love to hear how you both might schedule time to build testing into your project plans! Here's an issue where we can get organized on this too: publiclab/leaflet-environmental-layers#71 Thanks a lot, I know I've just shared a TON. Take your time processing this info, and please don't hesitate to ask questions, or point out where I've missed things or been unclear, or where you have new and great ideas to share! 🎉 Thanks so much for working with us!!!!! |
|
Yes that sounds great!! I'm going to take time to go through all the different lists and proposals and @crisner and I will decide how to coordinate our efforts! |
|
This is great..glad to work with you both..feel free to tag me incase of anything. Thanks |
|
I have listed a few tasks below for now and have tried to link them with existing issues. Hope to finish laying them out by tomorrow according to the tasks in our proposals. @nstjean, please edit this to add the tasks you have laid out. @jywarren I have a few questions that I have included at the end. [Natalie] We have added all items from our plots2 plan. Plots2All tasks for /map/ route are here: #6993
Update 'new post' location form:
Project: Redesign of location popup modal
Natalie's proposal included a possible design for the user profile location entry, this will need to be posted and input gathered as to what is the best way to accomplish it, how it should function and look.
Testing:
PL.Editor
LBL
LEL
Testing
Questions
Thanks. :-) |
|
I've updated @crisner 's post above with some tasks that I had planned for plots2. We had some overlap in LEL and we'll have to figure out who will take what! Also in the planning issue for geographic features for plots 2 there are more tasks for plots 2, and in the planning issue for LEL there are more as well. I created a large master-list of all the issues using a task planning tool to try to visualize them all. I sent the info over to @crisner so she can use it too. :) |
|
One question I have is about the location tools in Plots2. I notice that in some places it uses the pop-up modal, such as in your profile when you are adding a location. But then when you are writing a new post or page it shows an in-line form.
|
|
Hi all! Great questions, and great to hear from you all! I'll just jump right in:
Ideally it leads to a page which introduces LEL, and the lays out simple steps for suggesting/submitting a new layer idea (url, type, etc etc) so that we gradually add more layers. We don't yet have a simple way for non-developers to suggest layers, but we do have a
I think so! I saw a couple things - one, that it errors near the 360°/0° boundary publiclab/leaflet-blurred-location#213 and one just about the modal being really slow to appear #6897
Yeah, i'm not 100% sure, and open to ideas. I think that the current layer selection control in upper right has little enough information as to be not really very useful. There's no extra info about each layer, they are obscurely named, etc etc. So, maybe the bigger menu would just replace it entirely, and toggle on as you click that button in the corner?
That would be great, and can you highlight them specifically for feedback, too?
This sounds pretty good! Also note the relation between generating an embed code and generating a plots2 short code, aka an "inline powertag" (which we use to embed maps in plots2, and is explained here: https://publiclab.org/wiki/inline-maps). These are very similar if not quite redundant, although we don't use iframes on plots2, which is nice. So, the function which generates the embed code could easily be replaced with one which generates a short code for plots2, you know? And to @nstjean --
They should share a lot and look similar, for sure! But one is for the discrete activity of adding a location, while the other we wanted to appear more clearly as one step in the flow of crafting a post, so we didn't want it to be in a popup modal. Does this make sense? And the one in the editor also has additional features such as being able to fetch default zoom and lat/lon coordinates from the URL parameters, kind of like how @nfarve is working on here: #6858 I hope these help answer your questions! Please keep asking! Great day 1 😄 🎉 |
That makes sense! I do think they need to look more similar, I'd love to style the popup modal version to look more like the inline version. |
|
sure, want to share a mockup in an issue in
https://github.com/publiclab/leaflet-blurred-location/ ?
…On Tue, Dec 3, 2019 at 3:36 PM Natalie St Jean ***@***.***> wrote:
And to @nstjean <https://github.com/nstjean> --
Is there a reason for having two different location input forms?
Should we consolidate to just one or the other?
They should share a lot and look similar, for sure! But one is for the
discrete activity of adding a location, while the other we wanted to appear
more clearly as one step in the flow of crafting a post, so we didn't want
it to be in a popup modal. Does this make sense? And the one in the editor
also has additional features such as being able to fetch default zoom and
lat/lon coordinates from the URL parameters, kind of like how @nfarve
<https://github.com/nfarve> is working on here: #6858
<#6858>
That makes sense! I do think they need to look more similar, I'd love to
style the popup modal version to look more like the inline version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6887?email_source=notifications&email_token=AAAF6J5MKFQ5EZBJDJNOPVTQW27KHA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF2XJSA#issuecomment-561345736>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J3IATZZZW4YPYI234DQW27KHANCNFSM4JTZOL5A>
.
|
|
Ok, I'll work on a mockup. |
|
Another question while I'm thinking about it. Our original proposals had a timeline with tasks scheduled for each week. This is good for accountability and mentors making sure we are on track. With two of us working on the same large project would you rather we assign the tasks now while we plan, so we know who is in charge of what? Or would you prefer us if we worked through the list together, doing whatever task is next on the list? |
|
One can write the code and other can test that code. This will enable
better tests and better code. Like crisner wrote function A and nstjean
wrote tests for A. Then crisner wrote tests for function B written by
nstjean. This will encourage pair programming too.
Just a suggestion. Thanks
…On Wed, 4 Dec 2019, 8:36 am Natalie St Jean, ***@***.***> wrote:
Another question while I'm thinking about it.
Our original proposals had a timeline with tasks scheduled for each week.
This is good for accountability and mentors making sure we are on track.
With two of us working on the same large project would you rather we assign
the tasks now while we plan, so we know who is in charge of what? Or would
you prefer us if we worked through the list together, doing whatever task
is next on the list?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#6887?email_source=notifications&email_token=AFAAEQY62FEVTDVXZFGWUHTQW4NDJA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3SEAI#issuecomment-561455617>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAAEQZ4HQEVGK3WQAMFAT3QW4NDJANCNFSM4JTZOL5A>
.
|
|
@nstjean I have updated the list. |
|
@jywarren I have updated the task list. The ones with the 💡 emoji are the new features I had mentioned. Would like your feedback on implementing them. Would also like your feedback on the task below.
|
|
Another question. There are some tasks on the list which do not have their own issues. Do we create an issue for them before we begin working on those tasks? |
|
@nstjean and I have organized the tasks together. We will be dividing up tasks as we go. |
|
Will we need to post a week-by-week timeline of the tasks, as in our original proposals? |
Like, an updated timeline? do you think this would be useful for you both?
I think the idea here was just that if you've entered a location, we should also try to show it at an appropriate level of zoom, not just the whole world, centered on your location. When people put in locations, they often do so to a specific resolution/blur-level, because we use this kind of cool library we developed: https://github.com/publiclab/leaflet-blurred-location#how-it-works -- so, the precision of the lat/lon coordinates can be used to indicate a zoom level.
Yes please! What typically works is to make a list-style "planning issue" at first with checkboxes, and to split out just a few into their own issues, which you'll tackle first. Then spin out more separate issues as you go. This helps to not create a flood of issues all at once at the beginning, and if plans change as we learn more, we don't have to close a bunch of issues, we can just adjust the plan and those issues we have created so far. Thanks, i hope this makes sense!
This is partly up to you, in terms of what you both prefer. We don't have a strong preference and we will be paying enough attention to be aware of how you both split up the work, so we're not too worried about accountability in that regard. If it were me, I'd split up the next couple weeks worth of work at a pretty high resolution, so you don't step on each others' toes, but just have a more general idea of division of labor further out. And just check in every week to be sure you have the next couple weeks planned out sufficiently. We're a very cooperative community and while we appreciate independence, we are most interested in how community members support each other and rely on each others' complimentary and distinct skill sets. People have preferences on the kind of work you like to do, what you're good at, what you want to get better at, and what you enjoy offering support on (if you know a skill set very well). So, these factors may guide you in deciding who works on what parts. If you find that you need some support in making these decisions, I and the other mentors are happy to chime in with advice or guidance. So just reach out! Thanks, sorry this was a long response! |
|
Thanks all! Going through some now!
…On Wed, Jan 15, 2020 at 9:44 AM Natalie St Jean ***@***.***> wrote:
#7189 <#7189> is ready to merge
#7222 <#7222> is ready to merge
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6887?email_source=notifications&email_token=AAAF6J7PRXBZNJTBXW6TST3Q54N37A5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJAQ3NI#issuecomment-574688693>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J3MTKBV2XYKVVB5YYTQ54N37ANCNFSM4JTZOL5A>
.
|
|
Regarding popups not showing on markers: If we change this line Everything works fine then! One way to change this line is to use https://www.npmjs.com/package/patch-package , this changes that line in node modules folder after we do yarn install. The advantage is that we can still update leaflet version if there is any (we will kind of become static user of leaflet if we fork leaflet and do this change). Good night guys! |
|
oh goodness, i totally misunderstood, please forgive me @sagarpreet-chadha ! It's a Leaflet bug? I guess I'd prefer to fork Leaflet and fix it and point to our branch, but is it a known issue, that might be fixed by them soon? Or, is there any way for us to override this line in our code, after including Leaflet? @crisner @nstjean what do you think? I guess we should not hold back the publication of PublicLab.org if we don't have a quick path to fix this yet. I'm opening an issue where we can discuss this a bit more, would love to hear from you. Thanks! |
|
Can we create a pull request on Leaflet for the fix so it gets pushed through by them? I'm curious, did the popups used to work and now they don't? Or was this an ongoing issue? |
|
I think we need to collect up some more background on the state before and
the state now, and when it happened, and collect it in the new issue I
made, before making a final decision. Thanks!
…On Fri, Jan 17, 2020 at 2:15 PM Natalie St Jean ***@***.***> wrote:
Can we create a pull request on Leaflet for the fix so it gets pushed
through by them? I'm curious, did the popups used to work and now they
don't? Or was this an ongoing issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6887?email_source=notifications&email_token=AAAF6JZADIQOCNTMHKDZPZDQ6H7BVA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIVSZI#issuecomment-575756645>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6JYUHJ26E5O2XWMB57DQ6H7BVANCNFSM4JTZOL5A>
.
|
|
I'm so excited that yesterday I had success with the Jasmine tests! That was a long few days of repeated trial and failure. |
|
I added a fix for LEL publiclab/leaflet-environmental-layers#358 - might not be needed |
|
Commented/reviewed above PR's :) |
|
I also could use feedback here: publiclab/leaflet-blurred-location#233 (comment) |
|
I would also like some inputs on PR#356 |
|
Question about the map page here: #6993 (comment) Adding PLpeopleLayer to LEL: publiclab/leaflet-environmental-layers#361 [WIP] publiclab/leaflet-blurred-location#235 ready for merge |
|
Reviewed above PR's. Thanks!
…On Thu, 23 Jan 2020, 01:28 Natalie St Jean, ***@***.***> wrote:
Question about the map page here: #6993 (comment)
<#6993 (comment)>
Adding PLpeopleLayer to LEL: publiclab/leaflet-environmental-layers#361
<publiclab/leaflet-environmental-layers#361> [WIP]
publiclab/leaflet-blurred-location#235
<publiclab/leaflet-blurred-location#235> ready
for merge
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6887?email_source=notifications&email_token=ADSCRRPLFK5SMXGK32SZVBDQ7CQOBA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJU423A#issuecomment-577359212>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADSCRRPCX2YPMQEJCPB4GGDQ7CQOBANCNFSM4JTZOL5A>
.
|
|
publiclab/leaflet-blurred-location#235 - ready for merge publiclab/leaflet-environmental-layers#361 - ready for merge #7358 - should be ready, travis failed and needs to be restarted Would like feedback in LEL: There appears to be an error happening on some wiki pages - looks like just ones with an inline map. It's preventing use of the "add a location" button. I'll be looking at it more in depth tomorrow: #7346 |
|
Feedback needed for PR #367 |
|
Thanks all! Looked through these! |
|
publiclab/leaflet-blurred-location-display#95 - bumps LBL, ready for merge |
|
publiclab/leaflet-environmental-layers#368 - bumps LBL and also bumps the version number for LEL so that the changes can get pushed down to plots2. Ready for merge. |
|
#7425 ready for review and merge |
|
I'm going to close this up since the process has moved to #7432 !!! Thanks, all! |
First, congratulations again, and thank you for choosing Public Lab for your Outreachy fellowship! 🎉 🎉
I wanted to start to get our respective project plans aligned; first because we will have two fellows working together on this, and second, because there have been and will continue to be some other parallel and overlapping projects with connections to your work.
This project fits into a broader set of "Geographic systems" (https://github.com/publiclab/plots2/milestone/7) which were also worked on by @ananyaarun (during the last round of Outreachy) and others as well, including @sagarpreet-chadha, @cesswairimu, and more, both here in
plots2and in Leaflet Environmental Layers!@crisner has been doing some great work on the LEL library, while @nstjean has been doing some great work on the
plots2side of things, so this seems like, potentially, a natural complimentary arrangement. So, let's discuss a bit of each side and where the overlaps are!Original proposals
Resources
Some starting resources -- it's a good idea to read through our Style guide and Roadmap for a solid idea of how new features should be both planned and designed.
OK I am taking too long to post this so I'll just hit Publish and add more in a bit.
Welcome @crisner @nstjean and the Outreachy mentors! @ananyaarun @rexagod @cesswairimu @asquare14 @IshaGupta18 @MayankKashyap!
👋 🙌 🎉 💯 🔥
The text was updated successfully, but these errors were encountered: