Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysterious error message "User owmloading not found" shown #5095

Closed
harshkhandeparkar opened this issue Mar 15, 2019 · 34 comments · Fixed by publiclab/leaflet-environmental-layers#473 or #9212
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed help wanted requires help by anyone willing to contribute

Comments

@harshkhandeparkar
Copy link
Member

I got this error when I opened my profile
Screenshot_20190316_012912

I have used the website for the first time so please correct me if I have asked something wrong. Also my images were not posting on comments and even on profile image. Is this some internet problem or something else?

@grvsachdeva grvsachdeva added bug the issue is regarding one of our programs which faces problems when a certain task is executed help wanted requires help by anyone willing to contribute labels Mar 16, 2019
@madeofhuman
Copy link
Contributor

@gauravano @jywarren I want to look into this next.

@harshkhandeparkar
Copy link
Member Author

Can someone explain to me what this bug is?

@harshkhandeparkar
Copy link
Member Author

What does the error mean?

@grvsachdeva
Copy link
Member

That would be great @madeofhuman!

@grvsachdeva
Copy link
Member

@harshkhandeparkar Actually, this alert is shown in some instances, mostly in login flow. The reason for this is still not known.

@harshkhandeparkar
Copy link
Member Author

Uh ok. I was also not able to upload imgs. What could be the reason?

@grvsachdeva
Copy link
Member

grvsachdeva commented Mar 21, 2019 via email

@harshkhandeparkar
Copy link
Member Author

prod!

@harshkhandeparkar
Copy link
Member Author

I have good internet. 8MB/s upload

@grvsachdeva
Copy link
Member

There's an issue open for upload of the image in the comments. You faced issue there or somewhere else?

@harshkhandeparkar
Copy link
Member Author

Yes, in comments.

@CleverFool77
Copy link
Member

Hi
I faced similar issue while I was editing my note.

@harshkhandeparkar
Copy link
Member Author

harshkhandeparkar commented Mar 23, 2019

@gauravano I also couldn't upload a profile img.

@skilfullycurled
Copy link
Contributor

If it helps diagnose the problem, I've had this recently as well. For me, it reveals itself after clicking on a link to see a filtered list of my content from my profile.

For example: https://publiclab.org/tag/activity:*/author/bsugar

Doesn't effect any functionality.

Firefox 66.0.3
macOS 10.12.6

@jywarren
Copy link
Member

I think i got this. public/lib/leaflet-environmental-layers/dist/LeafletEnvironmentalLayers.js: imageLoadingUrl: 'owmloading.gif', // URL of loading image rela

this is an artifact from LEL, for the "loading" gif. it may try to load this at the wrong location here:

https://github.com/publiclab/leaflet-environmental-layers/blob/783409c0c903f3e14780a687bf2692462016f948/src/openWeatherMapLayer.js#L228

It's a relative location so that's why it shows up so many places. And you may get this notice on the next page load if this map gets loaded and it tries to fetch this .gif !

@ananyaarun @sagarpreet-chadha can we address this issue by eliminating that loading spinner and replacing it with a corrected relative path, or something similar? Maybe the ability to pass a root URL parameter on which to base relative URLs to this loading spinner? Or how does the regular spinner work? This is actually starting to cause system tests to fail, as well! Like in #5995.

Whew, this was a great one to find! Now we just have to solve it :-)

@skilfullycurled
Copy link
Contributor

Whew, this was a great one to find! Now we just have to solve it :-)

I'm glad you like it?

I mean, the bugs tend to find me not the other way around.

; )

@grvsachdeva
Copy link
Member

Wow!! this really took time.

@jywarren
Copy link
Member

I think this is now solved due to changes in upstream https://github.com/publiclab/leaflet-environmental-layers/! Thanks all!

@jywarren jywarren changed the title User owmloading not found Mysterious error message "User owmloading not found" shown Jun 16, 2020
@jywarren
Copy link
Member

This is now recurring again, noting relation to #7939

@jywarren jywarren reopened this Jun 16, 2020
@jywarren
Copy link
Member

Hi @Tlazypanda -- i reopened this and I think this is also in relation to the asset locations being defined relatively... do you think that may be right? Is it something we could monitor by watching the Chrome dev console while loading a map, and seeing how the path matches or doesn't match the location of the Leaflet assets? Thank you!

@jywarren
Copy link
Member

As you've been working on assets a lot, if you wouldn't mind adding this to your task list that would be super helpful!!

@skilfullycurled
Copy link
Contributor

skilfullycurled commented Jun 16, 2020 via email

@ebarry
Copy link
Member

ebarry commented Jun 17, 2020

Lol @skilfullycurled
This is somewhere between Little Bobby Tables and Public Lab's own ghost in the machine

@Tlazypanda
Copy link
Collaborator

Tlazypanda commented Jun 18, 2020

@skilfullycurled @ebarry That cracked me up lol 😂 @jywarren I found this on the lel live site might be of use: - investigating more to find out this ghost xD

image

@jywarren where are assets for lel stored? because i can't seem to find this file ... on checking this link out https://github.com/buche/leaflet-openweathermap/ found out that owmloading.gif should be stored at this path https://github.com/buche/leaflet-openweathermap/blob/master/example/leaflet/owmloading.gif. Tried with the local lel repo and the 404 error is not there anymore. Should I make this changes and open a pr on lel? 😅 We can also store this in a separate directory in lel (i don't know right now what is the one for assets like this on lel) and I will reference it in a relative manner then ✌️

@skilfullycurled
Copy link
Contributor

skilfullycurled commented Jun 18, 2020 via email

@jywarren
Copy link
Member

Hi! Thanks for investigating this!!!

I think we should see if this is referenced from a stylesheet, in which case we could override it with our own styles, or from JavaScript, in which case perhaps we can override it there? Can you look for the exact line of code where it happens and try to debug from there.

Overriding in JavaScript may be harder; see how Leaflet has allowed people to override image paths here: https://leafletjs.com/reference-1.4.0.html#icon-default-imagepath

So we could try to do something like that, either locally in our instance, or potentially filing an upstream PR to leaflet-openweathermap?

What do you think?

@ebarry
Copy link
Member

ebarry commented Jun 29, 2020

I think this is a candidate for our Hall of Fame label...

@Tlazypanda
Copy link
Collaborator

@jywarren Actually on using the git blame feature (thanks for telling me about this simplifies debugging a lot :D) came to know that this line was introduced in publiclab/leaflet-environmental-layers@f38d594 where we added the Openweather map module code but this code referenced the owmloading.gif too but this wasn't added.

https://github.com/publiclab/leaflet-environmental-layers/blob/f38d59419c4e88af855ec2172c1b5b44192a8be3/src/openWeatherMapLayer.js#L228

So following the Openweather map module(https://github.com/buche/leaflet-openweathermap/ - owmloading file was present from the initial commits of this library) so this had to be added in assets/images. Once I did that, and checked the examples/index in browser the error Failed to load resource: the server responded with a status of 404 () vanished. I have opened a pr for the same in LEL which is referenced above. Thanks ✌️

@ebarry
Copy link
Member

ebarry commented Jul 16, 2020

Another sighting of the fugitive owmloading 🔭
From browsing someone's profile page, i clicked the title of a research note, and when that note loaded, the red alert of owmloading appeared:

omw-loading

@stale stale bot added the stale label Oct 7, 2020
@publiclab publiclab deleted a comment from stale bot Oct 8, 2020
@stale stale bot removed the stale label Oct 8, 2020
@ebarry
Copy link
Member

ebarry commented Feb 10, 2021

👻 This just happened again.
I was on https://publiclab.org/profile/liz
and clicked "292 research notes"
then arrived at https://publiclab.org/notes/author/liz where the "ghost" appeared:
Screen Shot 2021-02-10 at 3 18 13 PM

@jywarren
Copy link
Member

Just an update - reading the above again, i see that "owmloading.gif" means "open weather map loading" and not a mis-spelling of "downloading" - lol!

https://github.com/buche/leaflet-openweathermap/blob/master/example/leaflet/owmloading.gif

publiclab/leaflet-environmental-layers#473 attempted to add it locally within LEL, which could work. I'll try that again, but we can also configure it here:

https://github.com/publiclab/leaflet-environmental-layers/blob/5c095304d0d5dcfc56950fccd5c5091dde891bef/src/openWeatherMapLayer.js#L226

cc @RuthNjeri

@jywarren
Copy link
Member

Progress at publiclab/leaflet-environmental-layers#504 once we get tests running again via GitHub actions for that repo! Then we'll bump the version and re-release.

jywarren added a commit that referenced this issue Feb 17, 2021
fix #5095 🎉 🎉 🎉 🎉 🎉  once LEL v2.4.3 merges!!!
jywarren added a commit that referenced this issue Feb 18, 2021
fix #5095 🎉 🎉 🎉 🎉 🎉  once LEL v2.4.3 merges!!!
@jywarren
Copy link
Member

Final fix in #9208, whew.

@cesswairimu
Copy link
Collaborator

Wow finally!!! this is awesome 🎉 🎉

lagunasmel pushed a commit to lagunasmel/plots2 that referenced this issue Mar 2, 2021
fix publiclab#5095 🎉 🎉 🎉 🎉 🎉  once LEL v2.4.3 merges!!!
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this issue Oct 16, 2021
fix publiclab#5095 🎉 🎉 🎉 🎉 🎉  once LEL v2.4.3 merges!!!
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021
fix publiclab#5095 🎉 🎉 🎉 🎉 🎉  once LEL v2.4.3 merges!!!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed help wanted requires help by anyone willing to contribute
Projects
None yet
9 participants