Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Scheduling of emails (pending Rails 4.2) #1584

Closed
1 of 7 tasks
StlMaris123 opened this issue Aug 22, 2017 · 5 comments
Closed
1 of 7 tasks

Active Scheduling of emails (pending Rails 4.2) #1584

StlMaris123 opened this issue Aug 22, 2017 · 5 comments
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration

Comments

@StlMaris123
Copy link
Collaborator

StlMaris123 commented Aug 22, 2017

This is a continuation of work done during GSOC 2017. To get an idea of what is supposed to be done, take a look at the link below to get the grasp of the workflow from what has been dine previously.

Relevant URLs

#1421

Active job is a dependency that come with Rails 4.2. Below is a breakdown of the tasks to handle:

  • Install ActiveJob dependencies (if any) locally
  • Using an ActiveJob tutorial (or docs) as an example, run a simple method once every minute
  • Run app locally and watch if that method is run in the logs
  • Add a database call to the method, to test that -- like incrementing the view count of a post, or changing the title to include Time.now.to_s and try refreshing the page to see it running.
  • In the method, now send an email to your own address with a clear title like Test ActiveJob email so that you can make an email rule to stop it from flooding your inbox :-).
  • Using resources like this, figure out if we can write a test for the email/activejob method
  • set the interval much longer, like 1 day
@jywarren jywarren added the break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration label Jan 16, 2018
@jywarren jywarren added this to the Email notifications overhaul milestone Jan 16, 2018
@jywarren
Copy link
Member

This requires Rails 4.2 to continue; in progress at #1832 -- thanks, @StlMaris123 !!

@jywarren jywarren changed the title Active Scheduling Active Scheduling of emails (pending Rails 4.2) Jan 16, 2018
@jywarren
Copy link
Member

And this will enable automatic sending of digests after #2027 is completed, too!

@grvsachdeva
Copy link
Member

Hi @jywarren , I would love to implement this as part of Email Integration Project for GSOC. Also,I have some great ideas and have worked about replying by emails to comments.

@jywarren
Copy link
Member

jywarren commented Feb 15, 2018 via email

@jywarren
Copy link
Member

jywarren commented May 3, 2018

Merging this into #2104! Thank you!!!!

@jywarren jywarren closed this as completed May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration
Projects
None yet
Development

No branches or pull requests

3 participants