Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly/ Monthly digest for publiclab.org #1119

Closed
1 of 4 tasks
ananyo2012 opened this issue Dec 17, 2016 · 18 comments
Closed
1 of 4 tasks

Weekly/ Monthly digest for publiclab.org #1119

ananyo2012 opened this issue Dec 17, 2016 · 18 comments
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration enhancement explains that the issue is to improve upon one of our existing features help wanted requires help by anyone willing to contribute planning Planning issues! Ruby

Comments

@ananyo2012
Copy link
Member

ananyo2012 commented Dec 17, 2016

Just thought of moving this to a separate issue Based on tag subscriptions we can send customized digest.
Digest can include research notes as well as questions.

Steps to solve

Rough steps that need to be followed

@ananyo2012 ananyo2012 added enhancement explains that the issue is to improve upon one of our existing features summer-of-code help wanted requires help by anyone willing to contribute Ruby design issue requires more design work and discussion (i.e. mockups and sketches) labels Dec 17, 2016
@jywarren
Copy link
Member

jywarren commented Dec 18, 2016

This may need to be broken into smaller parts to be effectively solved; adding break-me-up.

@jywarren jywarren added the break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration label Dec 18, 2016
@ananyo2012
Copy link
Member Author

@jywarren Yes please list way to break up the issue. This is labelled as a Google Code-in task so we need to make it as clear to students as possible. If it isn't taken by by end of the contest we can take it up ourselves as well.

@jywarren
Copy link
Member

jywarren commented Dec 19, 2016

I think this needs some thinking through -- but what about if:

(UPDATED: moved some issues over to #2104 and checked off or deleted remainder)

If we do this right, we can write tests against all of these steps before actually writing a mailer or testing by email, and we can ensure this'll work without having to do risky email testing on production!

@jywarren
Copy link
Member

Worked on breaking this up in #2027 and we'll need some of this in there too -- specifically the stuff in my last comment about finding the people who should get notified at a specific time! I think we may want to switch to a profile tag like digest:daily or digest:weekly and send to everyone once per day using that... not sure.

@jywarren jywarren removed the design issue requires more design work and discussion (i.e. mockups and sketches) label Jan 17, 2018
@steviepubliclab
Copy link
Contributor

This type of curated information could also be useful for the https://publiclab.org/wiki/requests page.

@ebarry
Copy link
Member

ebarry commented Jan 24, 2018

There seems to be language on the /subscriptions page that is both leftover from GoogleGroups and aspirational-but-not-yet-achieved until the features in this issue are created:

screen shot 2018-01-24 at 4 34 45 pm

The actual text reads:

Subscriptions let you keep up to date with topics on Public Lab. You can choose to receive them by email or in digest form.

We should remove the second sentence and just keep the first until these features exist.

Am i wrong?

@jywarren
Copy link
Member

Great -- however, we can change that to or view them in digest form linked to /subscriptions/digest as soon as #2058 is complete -- that implements the initial version of the weekly digest (although it's not emailed yet -- just displayed!)

@jywarren
Copy link
Member

This is really getting broken up into pieces and solved!!! :-) 👍 🎈 💥

@visheshruparelia
Copy link

I'd like to work on this for GSOC2018. Can anyone guide me further on this?

@steviepubliclab
Copy link
Contributor

steviepubliclab commented Feb 14, 2018 via email

@jywarren
Copy link
Member

Hi, @visheshruparelia -- please take a look through https://publiclab.github.io/community-toolbox/#r=all -- we'd love to have your help with one of those! Or if they're all taken, perhaps a https://github.com/publiclab/plots2/labels/help-wanted

however, if @Gauravano has an idea of where you could help with this one, maybe!

@ebarry
Copy link
Member

ebarry commented Feb 21, 2018

Great to see that https://publiclab.org/subscriptions/digest exists and is working!
What improvements should come next?

@jywarren
Copy link
Member

jywarren commented Feb 21, 2018 via email

@ViditChitkara
Copy link
Member

Hi everyone,
Thinking of using resque as the queuing backend for this (maybe we'd require capistrano for this work on production), @icarito could you please give your thoughts on this? Please look through https://publiclab.org/notes/vidit/02-16-2018/gsoc-18-email-notification-overhaul#c18986
@jywarren , @ebarry , @steviepubliclab , @ananyo2012 I'd love to have your reviews too.

@jywarren
Copy link
Member

Hi, i'll try to take a look tomorrow, thanks! Just returned from a long flight (dubai!). I'm going to add a few items to the top of this issue, though, including:

  • ability to change timeframe of /subscriptions/digest to weekly or monthly like Github Pulse has
  • should we try to merge some of the back-end methods (Tag or Node models) with those we use in the Tag pages, where we're also trying to enable time slices? Or the Stats pages?

@jywarren jywarren added the planning Planning issues! label May 3, 2018
@jywarren
Copy link
Member

jywarren commented May 3, 2018

@ViditChitkara perhaps we can try to summarize and consolidate as much as we can from this into your new planning issue? Or consolidate more here? Either way!

@ViditChitkara
Copy link
Member

I am comfortable with both!! I guess we can discuss things to be done on the planning issue.

@jywarren
Copy link
Member

jywarren commented May 3, 2018

Merging this into #2104 🎉

@jywarren jywarren closed this as completed May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration enhancement explains that the issue is to improve upon one of our existing features help wanted requires help by anyone willing to contribute planning Planning issues! Ruby
Projects
No open projects
Development

No branches or pull requests

6 participants