Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dark Mode For ImageSequencer #1824

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vivek-30
Copy link

Fixes #851. Now there will be a cool dark-mode for the image-sequencer.

@vivek-30 vivek-30 requested a review from a team as a code owner February 26, 2021 15:53
@gitpod-io
Copy link

gitpod-io bot commented Feb 26, 2021

@vivek-30
Copy link
Author

This is the Working Demo -

Screen.Recording.2021-02-26.at.9.16.42.PM.mov

@vivek-30
Copy link
Author

@jywarren , @harshkhandeparkar could you please review this 😊 .

@harshkhandeparkar
Copy link
Member

This is the Working Demo -

Screen.Recording.2021-02-26.ast.9.16.42.PM.mov

If that is the latest video then it still has many light elements...

@vivek-30
Copy link
Author

This is the Working Demo -
Screen.Recording.2021-02-26.ast.9.16.42.PM.mov

If that is the latest video then it still has many light elements...

@harshkhandeparkar are you talking about panel-body's ?

@harshkhandeparkar
Copy link
Member

are you talking about panel-body's ?

Those and the buttons.

@vivek-30
Copy link
Author

i have made the text white to highlight them in dark-mode and talking about the panels i don't fell like to change them as they look very decent with this theme.

@harshkhandeparkar
Copy link
Member

i have made the text white to highlight them in dark-mode and talking about the panels i don't fell like to change them as they look very decent with this theme.

I feel like grey will look better. This contrast is too high. What do you think?

@vivek-30
Copy link
Author

vivek-30 commented Feb 26, 2021

i have made the text white to highlight them in dark-mode and talking about the panels i don't fell like to change them as they look very decent with this theme.

I feel like grey will look better. This contrast is too high. What do you think?

ok i will give it a try. just a final confirmation grey color for panels and for button which color are you suggesting btw?

@harshkhandeparkar
Copy link
Member

ok i will give it a try. just a final confirmation grey color for panels and for button which color are you suggesting btw?

https://material.io/design/color/dark-theme.html maybe something like this

@jywarren
Copy link
Member

Hi all, thanks for the discussion! I'm wondering if there are some standard ways to implement this for Bootstrap that could involve just a single class being added, in addition to a standard CSS file?

https://duckduckgo.com/?q=bootstrap+4+dark+mode+css&atb=v121-6&ia=software

@vivek-30
Copy link
Author

@jywarren, @harshkhandeparkar is it ok if i will solve this further after few days later .
As i will be busy for next 3 weeks due to my college exams.
Also this feature will require significant amount of time to complete bcoz its not only about adding bootstrap classes. we
have to control the dynamic behaviour of the sequencer too.

look -

Screen.Recording.2021-02-27.at.8.36.31.PM.mov

i have tried to change the color for panels but it only changes for current one and does not apply when we add a new step

@vivek-30
Copy link
Author

BTW @jywarren #1819 is ready to for a review ,as i did all the requested changes. lastly Thank you sir for your time😊

@harshkhandeparkar harshkhandeparkar added almost-complete PRs that are almost done but little more work. and removed almost-complete PRs that are almost done but little more work. labels Jul 27, 2021
@harshkhandeparkar harshkhandeparkar marked this pull request as draft July 27, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[suggestion] Add Dark theme
3 participants