Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github action to publish demo at sequencer.publiclab.org #1703

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Aug 4, 2020

@gitpod-io
Copy link

gitpod-io bot commented Aug 4, 2020

@jywarren
Copy link
Member Author

jywarren commented Aug 4, 2020

How does this look? So to trigger it we publish a release on GitHub. We could alternatively try to trigger it on when the version number is incremented in the main branch?

@jywarren jywarren mentioned this pull request Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #1703 (6052e78) into main (853e719) will decrease coverage by 1.79%.
The diff coverage is 46.48%.

❗ Current head 6052e78 differs from pull request most recent head 782bc50. Consider uploading reports for the commit 782bc50 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1703      +/-   ##
==========================================
- Coverage   66.67%   64.88%   -1.80%     
==========================================
  Files         130      135       +5     
  Lines        2686     2828     +142     
  Branches      433      458      +25     
==========================================
+ Hits         1791     1835      +44     
- Misses        895      993      +98     
Impacted Files Coverage Δ
src/Modules.js 100.00% <ø> (ø)
src/modules/EdgeDetect/Module.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
src/modules/Shadow/Module.js 44.30% <44.30%> (ø)
src/modules/Overlay/Module.js 93.18% <94.11%> (-1.69%) ⬇️
src/modules/ColorHalftone/index.js 100.00% <100.00%> (ø)
src/modules/Colorbar/Module.js 100.00% <100.00%> (ø)
src/modules/Crop/Module.js 88.88% <100.00%> (ø)
src/modules/EdgeDetect/EdgeUtils.js 86.81% <100.00%> (-0.15%) ⬇️
... and 8 more

@jywarren
Copy link
Member Author

Noting this really cool script by @sagarpreet-chadha that generates a release -- https://github.com/publiclab/plots2/releases/tag/v4.0

Quoting myself from the chatroom --

@sagarpreet-chadha i love it. https://github.com/publiclab/plots2/releases/tag/v4.0 -- i'm really excited for it. I wonder if it could be a GitHub Action -- see how i'm trying to build one here - #1703 -- like, could it pull the "release author" from an issue or something? Or a PR? I dunno. Where is the script kept? Would we run this like once per week maybe? What if it were, like, built out of the weekly check-in?

anyways all just ideas... this is awesome as-is of course! Thanks!

@jywarren
Copy link
Member Author

OK! So, shall we refactor this to use the Bash script from #1739?

@harshkhandeparkar
Copy link
Member

yes!

@jywarren jywarren added this to the v3.7.0 milestone Oct 28, 2020
@jywarren jywarren added this to To Do in v3.7.0 Nov 1, 2020
@harshkhandeparkar harshkhandeparkar removed this from the v3.7.0 milestone Nov 2, 2020
@harshkhandeparkar harshkhandeparkar requested a review from a team as a code owner November 3, 2020 05:44
@harshkhandeparkar
Copy link
Member

@publiclab/is-maintainers Let's focus on this one next.

@harshkhandeparkar
Copy link
Member

I pushed something but I don't know if it is correct. @harshithpabbati ?

- uses: actions/checkout@v2
- name: Merge upstream
run: |
git config --global user.name 'jywarren'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do/is it required @jywarren?

@harshkhandeparkar harshkhandeparkar moved this from To Do to In Progress in v3.7.0 Jan 15, 2021
@@ -0,0 +1,16 @@
name: Publish sequencer.publiclab.org demo

on:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jywarren
Copy link
Member Author

jywarren commented Mar 18, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v3.7.x
In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants