Puavomenu lowres support #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because consistency is key to good quality. And why black? Because we already have it installed in our images, it does very good job out of the box and it's easy to integrate to any editor/ide/whatnot. Just: ``` black . ```
…icon sizes everywhere
… menu/program button icon sizes everywhere
…m button icon size and padding
…lays lowres = <1280x800 highres = >=1280x800 1280x800 seemed to be pretty good divider resolution. Height is the more important dimension. I tested with 864x486 and low res dims still allowed puavomenu to fit the screen. I could have squeezed the horizontal dimension too, for example by decreaseing the number of program cols from 4 to 3, but because 4 cols is the "standard" and 4 cols still fit 800x600, I left it alone to keep to UX pretty much the same as with high res dimensions.
Because resolution changes are quite common. But why this is handled in `launch` command? Because it's the safest and easiest way to ensure EVERYTHING get's re-initialized correctly with new dimensions in both dev and prod modes. New runtime, new everything. Quitting and restarting Gtk main loop does not give good results. And destroying the existing PuavoMenu and creating a new one when resolution is changed did not seem a safe option either. And dynamically changing dims is definitely not a good idea, the whole reason why we have these semi-static dimensions is that we create everything once based on the common set and then just live with it. So, restarting the whole runtime seemed the best option.
Because non-zero exit status for abnormal exits is a good thing.
tuomasjjrasanen
force-pushed
the
puavomenu_lowres_support
branch
from
d4c76e5
to
79da0fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of different logical parts:
Because the first commit touches all Python files, I strongly recommend to review this PR commit by commit.