Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wording in prune-backup command clearer #4754

Merged
merged 2 commits into from Aug 23, 2023

Conversation

Boy132
Copy link
Contributor

@Boy132 Boy132 commented Apr 17, 2023

This makes the wording of prune-backup command description a bit clearer.

@Aeris1One
Copy link

Pruning backups that are older than the pruning date is what it is intended for 🤔
The goal of pruning is the get rid of older backups...

@Boy132
Copy link
Contributor Author

Boy132 commented Apr 17, 2023

Pruning backups that are older than the pruning date is what it is intended for 🤔 The goal of pruning is the get rid of older backups...

Not according the command description:

Marks all backups that have not completed in the last "n" minutes as being failed.

@Aeris1One
Copy link

Oh, sorry, misunderstood what you were talking about.

Marks all backups that have not completed in the last "n" minutes as being failed.

could be rephrased as

Marks all backups that have not completed and were created more that "n" minutes ago as being failed.

I agree the wording is kind of bad, but the command is about marking as failed all backups that are stuck for more than "n" minutes.
I can't see the point of a command that mark all backups started less than "n" minutes ago and aren't completed as failed. That would mean that even backup that are not failed and still ongoing (because launched some seconds ago maybe, so perfectly normal they are still running) would be marked as failed.

@Boy132
Copy link
Contributor Author

Boy132 commented Apr 17, 2023

I agree the wording is kind of bad, but the command is about marking as failed all backups that are stuck for more than "n" minutes. I can't see the point of a command that mark all backups started less than "n" minutes ago and aren't completed as failed. That would mean that even backup that are not failed and still ongoing (because launched some seconds ago maybe, so perfectly normal they are still running) would be marked as failed.

I see your point. And I agree that makes more sense. I changed the PR to only change the wording so it's clearer.
Thanks for pointing that out!

@Boy132 Boy132 changed the title Flip opperator for prune age check in prune-backup command Make wording in prune-backup command clearer Apr 17, 2023
@matthewpi matthewpi merged commit 51cee76 into pterodactyl:1.0-develop Aug 23, 2023
7 checks passed
@Boy132 Boy132 deleted the patch-2 branch August 23, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Released
Development

Successfully merging this pull request may close these issues.

None yet

3 participants