Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Search Bar #3926

Closed
wants to merge 91 commits into from
Closed

File Search Bar #3926

wants to merge 91 commits into from

Conversation

mrxbox98
Copy link
Contributor

This pr adds a search bar to the file manager.

closes #3503

Jelcoo
Jelcoo reviewed Jan 30, 2022
View reviewed changes
Copy link
Contributor

@Jelcoo Jelcoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix some things

resources/scripts/components/server/files/FileManagerContainer.tsx Show resolved Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx Show resolved Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx Outdated Show resolved Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx Outdated Show resolved Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx Outdated Show resolved Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx Outdated Show resolved Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx Outdated Show resolved Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx Outdated Show resolved Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx Outdated Show resolved Hide resolved
@Jelcoo
Copy link
Contributor

Jelcoo commented Jan 30, 2022

Implementation is not very good. It covers directory names, and it also can't search in directories
firefox_sZU6YRgz0S

@mrxbox98
Copy link
Contributor Author

Implementation is not very good. It covers directory names, and it also can't search in directories firefox_sZU6YRgz0S

Directory name issue fixed in 43d44da. Also I am able to search in directories.

@Jelcoo
Copy link
Contributor

Jelcoo commented Jan 31, 2022

You can search when you're inside a folder, but not when you're in the main directory and want to search in other directories. I was the one that made the issue about this feature request, and that is the way I had in mind.

@mrxbox98
Copy link
Contributor Author

You can search when you're inside a folder, but not when you're in the main directory and want to search in other directories. I was the one that made the issue about this feature request, and that is the way I had in mind.

From what I can tell this is only possible with modifications to wings as only the files/folders the user is viewing are sent by wings.

@yesBad
Copy link

yesBad commented Feb 4, 2022

How does it look on mobile?

@mrxbox98
Copy link
Contributor Author

mrxbox98 commented Feb 4, 2022

How does it look on mobile?

Like this
Screenshot from 2022-02-04 07-14-46

@FoksVHox
Copy link
Contributor

FoksVHox commented Feb 5, 2022

Does the searchbar still overlap the filestructurr breadcrumbs, on desktop?

@mrxbox98
Copy link
Contributor Author

mrxbox98 commented Feb 5, 2022

Does the searchbar still overlap the filestructurr breadcrumbs, on desktop?

Nope

@FoksVHox
Copy link
Contributor

FoksVHox commented Feb 6, 2022

Does the searchbar still overlap the filestructurr breadcrumbs, on desktop?

Nope

Glad to hear.

I however feel that the mobile version should have a little more work done, so that it matches with the quality of the rest of the ui

@YomoSK YomoSK mentioned this pull request Mar 15, 2022
Closed
1 task
DaneEveritt
DaneEveritt requested changes Mar 28, 2022
View reviewed changes
resources/scripts/components/server/files/FileManagerBreadcrumbs.tsx Outdated
@@ -36,7 +36,7 @@ export default ({ renderLeft, withinFileEditor, isNewFile }: Props) => {
});

return (
<div css={tw`flex flex-grow-0 items-center text-sm text-neutral-500 overflow-x-hidden`}>
<div css={tw`flex flex-grow-0 items-center text-sm text-neutral-500`}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change made?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory path would be masked by the input field if overflow-x-hidden was present.

resources/scripts/components/server/files/FileManagerContainer.tsx Outdated Show resolved Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx Outdated Show resolved Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx Outdated Show resolved Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx Outdated Show resolved Hide resolved
@mrxbox98
Copy link
Contributor Author

Updated UI:
Regular Desktop

Mobile:
iPhone XR

@tmunsch
Copy link

tmunsch commented Sep 29, 2022

Nice work!

@mrxbox98
Copy link
Contributor Author

@matthewpi Could you review this when you have time

@matthewpi
yarn: upgrade dependencies
7c67ff3
@matthewpi
ui(server): lazy load server console to reduce main bundle size
d8b7747
@matthewpi
nix: update flake lock
c5be3ad
@matthewpi
Merge branch '1.0-develop' into develop
3bd8164
@matthewpi
Merge branch '1.0-develop' into develop
582c50c
@matthewpi
Merge branch '1.0-develop' into develop
18f6611
@matthewpi
composer: update lock
a1e5afc
@matthewpi
ci(laravel): add PHP 8.2 to test matrix
85df1a4
@matthewpi
nix: update flake lock
733771a
@matthewpi
app(services): fix DeployServerDatabaseService phpstan
0af3949
@matthewpi
yarn: upgrade dependencies
187c7f7
@matthewpi
ci(docker): upgrade to php 8.2
2195aa6
@matthewpi
ui: fix prettier
673f728
@matthewpi
ci(container): replace old docker workflow
ab4b4e6
@matthewpi
ci(container): update to ubuntu-22.04
f98aa11
@matthewpi
ci(container): tweak options
05d8de0
@matthewpi
containerfile: reinstall tzdata
7241829 
ref; https://bugzilla.redhat.com/show_bug.cgi?id=1870814
@matthewpi
containerfile: remove platform arg
8ae40a7
@matthewpi
ci(docker): revert workflow changes
0d225b0
@matthewpi
switch from yarn to pnpm
8320c64
@matthewpi
ci: install pnpm
f5ce1a2
@matthewpi
Merge branch '1.0-develop' into develop
dc6fadd
@matthewpi
Update README.md
bad7650
@matthewpi
Merge branch '1.0-develop' into develop
eaf4642
@matthewpi
Merge branch '1.0-develop' into develop
b7b128e
@matthewpi
Merge branch '1.0-develop' into develop
d3c6568
@matthewpi
Merge branch '1.0-develop' into develop
6f5fb09
@mrxbox98 mrxbox98 changed the base branch from develop to 1.0-develop August 31, 2023 07:37
@mrxbox98 mrxbox98 closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jelcoo Jelcoo Jelcoo left review comments

@DaneEveritt DaneEveritt Awaiting requested review from DaneEveritt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Searching for files
10 participants
@mrxbox98 @Jelcoo @yesBad @FoksVHox @tmunsch @DaneEveritt @JustOptimize @antoari @matthewpi @lancepioch