Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply/Quote comments #42

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

frandiox
Copy link
Contributor

@psychobunny This implements reply/quote to blog comments. It also adds a label that scrolls to the replied comment (similar to NodeBB's one).
This is meant to be a basic implementation. It would be better to use a scrolling animation rather than scrollIntoView, for example.

capture

(The font-size is different in the image due to some local CSS)

I included also a link to the user profile from username because on small resolutions the profile pictures are hidden (those are the links right now).

And by the way, I couldn't figure out how to access to <!-- IF posts.toPid --> (it can be a string or undefined) and {posts.parent.username}, so I had to create posts.isReply and posts.parentUsername. If you know a better way I can change it.

@frandiox
Copy link
Contributor Author

It seems that a reply to a purged post contains parent object without parent.username inside, so it's possible to remove the "reply-label" from those posts. However, in the case of replies to deleted posts (not purged), I think there is no way to differentiate from normal replies.
/api/topic/id/... returns deleted posts as well, but the blog comments uses a different request which does not proportionate them.
I notice that in NodeBB itself a reply to a purged post will show the label without any content, what I guess it's a bug.

@frandiox frandiox force-pushed the reply-comments branch 3 times, most recently from bd3f1df to 6b2798d Compare January 14, 2016 11:43
@revir
Copy link
Contributor

revir commented Jan 15, 2017

I used this patch in https://github.com/revir/nodebb-plugin-blog-comments2
It works as I desired, thank you!
But you seems to forget handling unlogined reply, but everything others is good :)

@frandiox
Copy link
Contributor Author

frandiox commented Jan 15, 2017

@revir Thanks! That's true, I forgot to hide the buttons when it's not logged in, my bad. I will try to update the PR when I have some time. I think this is still useful for some users even though I doubt it will be merged to the main repo at this point 😅
For other users, live demo here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants