Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for invalid email address #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

npnigro
Copy link
Contributor

@npnigro npnigro commented Jul 18, 2017

Strip out '#' from unique name. This helps address an issue with external users that have a Microsoft account (as opposed to a Work/School account).

Strip out '#' from unique name. This helps address an issue with external users that have a Microsoft account (as opposed to a Work/School account).
@psignoret
Copy link
Owner

Let me dig into this a bit more and see what options there are. I'm not a fan of just taking whatever comes after the # character, because I can only assume that can change in the future (it has already changed once, if I'm not mistaken).

@npnigro
Copy link
Contributor Author

npnigro commented Jul 18, 2017

I hear you, but the code on the trunk doesn't work for these users. It's a patch of a known/reproducible issue, at least.

@psignoret
Copy link
Owner

It is, but this patch results in state which gets persisted in WordPress. If we find there's a better way to do this (e.g. a better way to get the unique email-like username), then it'll be too late for any user who was provisioned in this way.

@npnigro
Copy link
Contributor Author

npnigro commented Jul 18, 2017

Good point. I suppose you could make it so the username includes the hashtag and only strip it out of the email address since we know that won't work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants