Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sessions.py #2114

Closed
wants to merge 1 commit into from
Closed

Update sessions.py #2114

wants to merge 1 commit into from

Conversation

manizzle
Copy link

@manizzle manizzle commented Jul 1, 2014

allow Session to set a timeout for requests

allow Session to set a timeout for requests
@Lukasa
Copy link
Member

Lukasa commented Jul 1, 2014

Thanks for this!

Unfortunately, this is a feature request that comes up often but that we don't have any real interest in. See #2011 for a longer form justification. For this reason, I'm afraid that we can't accept this pull request. Thanks so much for the work though, and please do keep contributing! 🍰

@Lukasa Lukasa closed this Jul 1, 2014
@manizzle
Copy link
Author

manizzle commented Jul 1, 2014

Thanks. The documentation should probably updated. http://docs.python-requests.org/en/v0.10.6/api/#requests.Session

@Lukasa
Copy link
Member

Lukasa commented Jul 1, 2014

You just linked to the v0.10.6 documentation. Try looking at the latest version: http://docs.python-requests.org/en/latest/api/#requests.Session

@sigmavirus24
Copy link
Contributor

@manizzle you're linking to an ancient version of the documentation (you can see it in the URL v0.10.6). The current documentation is fine: http://docs.python-requests.org/en/latest/user/advanced/#session-objects

@manizzle
Copy link
Author

manizzle commented Jul 1, 2014

Okay thanks

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants