Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idna version pin does not allow version 2.7 #4681

Closed
jakul opened this issue Jun 11, 2018 · 3 comments
Closed

idna version pin does not allow version 2.7 #4681

jakul opened this issue Jun 11, 2018 · 3 comments

Comments

@jakul
Copy link

jakul commented Jun 11, 2018

idna have just released 2.7. requests is pinned to idna>=2.5,<2.7

https://github.com/requests/requests/blob/d1aeb7ea8cec833e61ea390a6c19ef8b7ac3e4e7/setup.py#L53

Can the pin be updated to allow v2.7?
@nateprewitt
Copy link
Member

Hi @jakul, this is addressed (generally, replace "urllib3" with "idna") in #4673 (comment). We'll update our version pins in the next release of Requests (which will likely be this week). Thanks for letting us know!

@gbrady92 gbrady92 mentioned this issue Jun 11, 2018
Closed
@m1yag1 m1yag1 mentioned this issue Jun 11, 2018
Merged
@edmorley edmorley mentioned this issue Jun 11, 2018
Merged
@prometheanfire
Copy link

hitting it in openstack as well now.

http://logs.openstack.org/40/574140/2/check/requirements-tox-py27-check-uc/7a0ed61/job-output.txt.gz#_2018-06-11_17_06_11_715280

@dannyroberts dannyroberts mentioned this issue Jun 11, 2018
Merged
@glasserc glasserc mentioned this issue Jun 12, 2018
Merged
@lnielsen lnielsen mentioned this issue Jun 12, 2018
Closed
@nateprewitt
Copy link
Member

Alright, 2.19.0 is out the door! Closing this out since it should be resolved now.

openstack-gerrit pushed a commit to openstack/requirements that referenced this issue Jun 13, 2018
@prometheanfire
Updated from generate-constraints
939fc66 
networkx kept at 1.11 for breakage
  * bugs.launchpad.net/openstack-requirements/+bug/1718576
google-auth and google-api-python-client kept at current for cinder breakage
  * bugs.launchpad.net/openstack-requirements/+bug/1775218
eventlet kept at 0.20.0 for breakage
Sphinx kep at 1.6.5 for docs breakage
pyldap, removed post1 again
urllib3 is being held back because of requests
  * psf/requests#4673
idna is being held back by requests as well
  * psf/requests#4681
pexpect is being held back for ansible-runner
  * ansible/ansible-runner#44

Change-Id: I90626ff9d65ab0df875d2c5a2d058a472631f1b6
@dannyroberts dannyroberts mentioned this issue Jun 19, 2018
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakul @prometheanfire @nateprewitt