Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to build due to versions incompatibility/collision #265

Closed
ppanero opened this issue Jun 11, 2018 · 3 comments
Closed

Not able to build due to versions incompatibility/collision #265

ppanero opened this issue Jun 11, 2018 · 3 comments

Comments

@ppanero
Copy link
Member

ppanero commented Jun 11, 2018

Cryptography has pinned idna >= 2.1
Requests has pinned idna>=2.5,<2.7

Lastest idna release is 2.7 Therefore it fails to build. In my own project I have fixed it pinning the dependency but maybe it is nice to pin it here too.

@lnielsen
Copy link
Member

This is identical to #243 which happened when idna v2.6 was released. Requests library is set to be updated within a week (see psf/requests#4681) which will solve the issue, but we'll have the same problem again when idna v2.8 is released so likely we need to do something about it so it won't break in the future.

That said, probably the place idna should be pinned is not in invenio-accounts, since there's no dependency on requests.

@ppanero
Copy link
Member Author

ppanero commented Jun 12, 2018

Hmm its true there is not dependency on requests but there is on Cryptography (which has a dependency on idna). Im closing this, since is easily solvable by pinning in my own app. If you consider necessary open again, happy to help.

And Thanks for the info!

@ppanero ppanero closed this as completed Jun 12, 2018
@lnielsen
Copy link
Member

I think it's still an issue, but I'm not sure where the dependency comes from - this is definitely going to happen again in the future, so I'm quite sure we need to pin idna, just need to be in the right package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants