Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use same clang-format-lint-action in Makefile and CI #897

Merged
merged 1 commit into from Mar 21, 2023

Conversation

bignaux
Copy link
Member

@bignaux bignaux commented Mar 19, 2023

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

makes the use of format and format-check targets easier for developers by doing exactly the same thing as on the CI side.
Would avoid format issue as in #891

@AKuHAK
Copy link
Member

AKuHAK commented Mar 20, 2023

Why did you add thirdparty into gitignore?

@bignaux
Copy link
Member Author

bignaux commented Mar 20, 2023

i just added for thirdparty/clang-format-lint-action , to prevent git to list them as untracked files. btw ideally, external dependancies would be outside the OPL directory and shared between projects, but i don't want to go into this flamewar again if people are not interested.

@AKuHAK
Copy link
Member

AKuHAK commented Mar 21, 2023

Doh, phone doesnt show me that it not folder but file, you are correct. Also, you hardcoded 12 as clang format version. Is it possible to somehow "latest" instead? I mean when they release 13 version, we dont have to update script.

@bignaux
Copy link
Member Author

bignaux commented Mar 21, 2023

There is no "latest" and default is 9. Upgrading from 12 would make lot of file changes, wasn't the scope of this commit. If you want to go to 15, i could do another commit if you want.

@AKuHAK AKuHAK merged commit c3a2ef4 into ps2homebrew:master Mar 21, 2023
@bignaux bignaux deleted the format branch March 21, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants