Add in support for using PS3 Guitars as PS2 Guitars in PADEMU

[sanjay900]

To do this, I added in support for parsing the PS3 Guitar reports, as the hid report format for PS3 Instruments differs from the standard controller. I also added in support for PADEMU to support different models, as PS2 guitars use a different model in the query model and mode command. I also force hold dpad left, as this is another thing the games use for detecting guitars.

For PS3 Guitar Hero Guitars, I map the accelerometer once it hits certain ranges, while for RB Guitars i just map the tilt bit directly as it is still digital on those.

For the frets, I use the RB style mappings as most other instruments except for the PS3 Guitar Hero Guitar use that format, and then when translating the pad I swap yellow and blue for guitar hero guitars.

Pull Request checklist

Note: these are not necessarily requirements

• I reformatted the code with clang-format
• I checked to make sure my submission worked
• I am the author of submission or have permission from the original author
• [] Requires update of the PS2SDK or other dependencies
• Others (please specify below)

Pull Request description

[sanjay900]

If you want to test this but don't have a PS3 guitar handy, I actually wrote these changes to support some firmware I am working on for various microcontrollers for emulating various instruments, so if you have a spare pi pico or arduino hanging around you can also just emulate a guitar with https://sanjay900.github.io/guitar-configurator

[sanjay900]

I had it tested with original hardware for both PS3 Guitar Hero Guitars, and PS3 Rock Band guitars, and everything works, including tilt.

[AKuHAK]

@sanjay900 it seems that you are actively working on this pr, let us know when it will be ready for review.

[sanjay900]

I am done with it now, had a few more people test it and fixed it up after some feedback.
@AKuHAK

[AKuHAK]

@sanjay900 can you check with opl test iso how much opl uses ram without your additions, and how much with? If these changes requires too much ram, maybe it will be useful to add additional setting for it.

[sanjay900]

@sanjay900 can you check with opl test iso how much opl uses ram without your additions, and how much with? If these changes requires too much ram, maybe it will be useful to add additional setting for it.

Can this easily be done without a console? I don't actually own a PS2 myself. If you gave me some instructions on how to do this i might be able to get someone to test it for me, but I'm not actually sure how to test the ram usage myself.

[AKuHAK]

Can this easily be done without a console? I don't actually own a PS2 myself. If you gave me some instructions on how to do this i might be able to get someone to test it for me, but I'm not actually sure how to test the ram usage myself.

Oh, but how are you testing guitar support then? Anyway, you just put iso into USB DVD folder and run it as usual, with enabled pademu. Then you compile version with and without your changes and just run both versions with enabled pademu and all other settings the same.

[sanjay900]

Can this easily be done without a console? I don't actually own a PS2 myself. If you gave me some instructions on how to do this i might be able to get someone to test it for me, but I'm not actually sure how to test the ram usage myself.

Oh, but how are you testing guitar support then? Anyway, you just put iso into USB DVD folder and run it as usual, with enabled pademu. Then you compile version with and without your changes and just run both versions with enabled pademu and all other settings the same.

I sent a link with a download in a discord server with a bunch of people who play / mod older guitar games, and a bunch of people tested it with various different guitars. I'll flick these instructions to someone and report back.

Where abouts can I obtain a copy of the opl test iso from @AKuHAK ?

[AKuHAK]

https://github.com/AKuHAK/Open-PS2-Loader/actions/runs/4472113456
In the artifacts section

[sanjay900]

@AKuHAK

With my changes

Without my changes

[AKuHAK]

So with your changes it uses less RAM? -512 bytes from what I see. Nice, I hope that you didnt mix the screenshots. anyway 512 byte difference isnt much, so its acceptable. If you can confirm that normal pademu still works after your changes, I think that your pr can be merged without problems.

[sanjay900]

So with your changes it uses less RAM? -512 bytes from what I see. Nice, I hope that you didnt mix the screenshots. anyway 512 byte difference isnt much, so its acceptable. If you can confirm that normal pademu still works after your changes, I think that your pr can be merged without problems.

Lol yep I did switch the screenshots, whoops
I'll ask someone to check that it works normally still.

[sanjay900]

@AKuHAK just got confirmation that it is still fully working with standard PS3 controllers, so normal PADEMU is still working.

[AKuHAK]

@sanjay900 can you take a look at this issue?

[ZavEntNet]

Multiplayer Mode is Unplayable using 2 PS3 Guitars, tested on GH1, GH2 and Rock 80's, Can You solve this ??

[sanjay900]

Multiplayer Mode is Unplayable using 2 PS3 Guitars, tested on GH1, GH2 and Rock 80's, Can You solve this ??

I don't really know enough about PADEMU to know why this would be the case, so i wont be able to fix it