Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dispatch debug builds to tagged release assets #808

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

dispatch debug builds to tagged release assets #808

wants to merge 2 commits into from

Conversation

israpps
Copy link
Member

@israpps israpps commented Nov 16, 2022 •
edited

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

@AKuHAK
Copy link
Member

AKuHAK commented Nov 27, 2022

Not quite sure but do we really need debug builds when releasing major release builds?

@israpps
Copy link
Member Author

israpps commented Nov 27, 2022

Not quite sure but do we really need debug builds when releasing major release builds?

Seems reasonable to me.

Better regression testing maybe?

And anyways, it won't take too much space, since tagged releases are something rarely seen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MobarakeGH MobarakeGH MobarakeGH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@israpps @AKuHAK @MobarakeGH