-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kr_ps2: Compatibility Enhancement: Improved Configuration Handling #1194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm. I've been planning to do this for a while myself
mc0:/BOOT/BOOT.ELF > IGR > wLE_kHn @AKuHAK, PS2LOGO works well. I have not tested PADEMU and PS2RD. Also, I could not test the long IGR path, since in the OPL settings you cannot write more than 32 characters. |
This is different problem not related to opl. Here is an issue. Thanks for confirming that the spaces works fine. |
WIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to check if everything is ok. But in general this looks like a good improvement. So LGTM.
Merge?
Yes, it can be merged, partially tested and is ok. |
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
kr_ps2:
This pull request addresses the compatibility issue between OPL and
ee_core
, resolving a situation where configurations were being loaded by passing parameters, resulting in convoluted processes and difficulties in understanding the sequence of operations. The previous method was prone to exceeding parameter limits and causing confusion. The proposed changes replace the previous approach with a more efficient and organized solution.Furthermore, the IGR exit path has been increased to 256 and logic changed so now spaces allowed in path.
PS2LOGO, PADEMU, IGR, cheats were not tested, looking for testers.
fixes #676