Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kr_ps2: Compatibility Enhancement: Improved Configuration Handling #1194

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

AKuHAK
Copy link
Member

@AKuHAK AKuHAK commented Mar 7, 2024

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

kr_ps2:
This pull request addresses the compatibility issue between OPL and ee_core, resolving a situation where configurations were being loaded by passing parameters, resulting in convoluted processes and difficulties in understanding the sequence of operations. The previous method was prone to exceeding parameter limits and causing confusion. The proposed changes replace the previous approach with a more efficient and organized solution.

Furthermore, the IGR exit path has been increased to 256 and logic changed so now spaces allowed in path.

PS2LOGO, PADEMU, IGR, cheats were not tested, looking for testers.

fixes #676

Copy link
Member

@uyjulian uyjulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm. I've been planning to do this for a while myself

@AKuHAK
Copy link
Member Author

AKuHAK commented Mar 10, 2024

@10522 just to confirm. You tested this elf and

  1. you checked first that IGR without spaces does work
  2. you checked second that IGR with spaces doesn't work

Cause from your report in #676 it isnt clear if you did first step.

@10522
Copy link

10522 commented Mar 10, 2024

mc0:/BOOT/BOOT.ELF > IGR > wLE_kHn
mc0:/BOOT/BOOT 2.ELF > IGR > wLE_kHn
mass:/BOOT/BOOT.ELF > IGR > PS2 Browser
mass:/BOOT 2.ELF > IGR > PS2 Browser

@AKuHAK, PS2LOGO works well. I have not tested PADEMU and PS2RD. Also, I could not test the long IGR path, since in the OPL settings you cannot write more than 32 characters.

@AKuHAK
Copy link
Member Author

AKuHAK commented Mar 11, 2024

mass:/BOOT/BOOT.ELF > IGR > PS2 Browser
mass:/BOOT 2.ELF > IGR > PS2 Browser

This is different problem not related to opl. Here is an issue. Thanks for confirming that the spaces works fine.

@AKuHAK AKuHAK marked this pull request as draft March 11, 2024 19:30
@AKuHAK
Copy link
Member Author

AKuHAK commented Mar 11, 2024

in the OPL settings you cannot write more than 32 characters.

WIP

@AKuHAK AKuHAK marked this pull request as ready for review March 13, 2024 08:33
Copy link
Member

@rickgaiser rickgaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to check if everything is ok. But in general this looks like a good improvement. So LGTM.

Merge?

@AKuHAK
Copy link
Member Author

AKuHAK commented Mar 13, 2024

Yes, it can be merged, partially tested and is ok.

@rickgaiser rickgaiser merged commit f5a0d27 into ps2homebrew:master Mar 13, 2024
26 checks passed
@AKuHAK AKuHAK deleted the kr_eecore branch March 16, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE]: IGR path breaking games
4 participants