feat: support $unknownFields #1912
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indutny-signal
force-pushed
the
feature/unknown-fields-v2
branch
from
ae522da
to
27592aa
Compare
This add `$unknownFields` property to generated code. It is populated on `.decode()` when decoder encounters currently unknown field, and similarly used by encoder to serialize unknown fields as they are into a binary data. If user stores unknown fields and then upgrades their protobufs to the latest spec - there is a chance that some of the previously unknown fields will become known. This is handled in the encoder by attempting to decode the fields first. The name of the field starts with `$` because it is not a valid character for a field name according to protobuf v3 specification.
indutny-signal
force-pushed
the
feature/unknown-fields-v2
branch
from
27592aa
to
5875cbf
Compare
|
Thanks @indutny-signal! We'll need some time to review this one but we'll try to do it soon. |
|
Thanks a lot! FWIW, most of the changes are just generated code in tests. I can probably rip it out of the Pull Request if you'd like! |
Open
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add
$unknownFieldsproperty to generated code. It is populated on.decode()when decoder encounters currently unknown field, and similarly used by encoder to serialize unknown fields as they are into a binary data.If user stores unknown fields and then upgrades their protobufs to the latest spec - there is a chance that some of the previously unknown fields will become known. This is handled in the encoder by attempting to decode the fields first.
The name of the field starts with
$because it is not a valid character for a field name according to protobuf v3 specification.