Add support for longs: BigInt
in toObject
#1908
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
toObject({ longs: BigInt })
, which converts longs to native BigInts.This is structured as opt-in so that hopefully it can be shipped in a minor update without having to wait for a 8.x release.
I tested performance of conversion using both
DataView.getBig(U)Int64
and plain bitwise arithmetic: https://jsbench.me/1lljqc4kd7/2 The DataView version was faster, but since getBig(U)Int64 is a relatively more recent addition, I provided a fallback for environments that don't support it.See also:
Motivation:
Currently we are maintaining a patch for protobufjs in foxglove/studio. In order to publish some of these packages to NPM, we replace the patch with something that can actually be shipped in
dependencies
.