Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 6.9.0 #1374

Merged
merged 3 commits into from Apr 20, 2020
Merged

chore: release 6.9.0 #1374

merged 3 commits into from Apr 20, 2020

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Mar 11, 2020

馃 I have created a release *beep* *boop*

6.9.0 (2020-04-17)

Features

Bug Fixes

  • allow file-level options everywhere in the file (b70eebd)
  • Import Long types (1d98cb8)
  • npm audit fixes (ca52447)
  • properly iterate and return method descriptors (d96bb7a)
  • run npm audit fix (#1208) (b5b6632)
  • docs: update CHANGELOG to match format of release-please (#1376) (15ed8a0)

This PR was generated with Release Please.

@bcoe
Copy link
Contributor

bcoe commented Mar 11, 2020

This PR is magical 猸愶笍, It's generated automatically by the tool release-please, based on the commit history (it understands conventional commits which we've been starting to use for newer commits we land).

When landed, this PR will automatically create a GitHub release, but will not yet publish to npm; this is an option for us to setup in the future if we would like, and we're getting good about labeling our commits.

CC: @dcodeIO, wanted to make sure you're in the loop on this update, and are okay with the approach.

CHANGELOG.md Outdated
## Fixed
[:hash:](https://github.com/dcodeIO/protobuf.js/commit/e8449c4bf1269a2cc423708db6f0b47a383d33f0) Fix package browser field descriptor ([#1046](https://github.com/dcodeIO/protobuf.js/issues/1046))<br />
[:hash:](https://github.com/dcodeIO/protobuf.js/commit/996b3fa0c598ecc73302bfc39208c44830f07b1a) Fix static codegen issues with uglifyjs3<br />
[:hash:](https://github.com/dcodeIO/protobuf.js/commit/a06317139b92fdd8c6b3b188fb7b9704dc8ccbf1) Fix lint issues / pbts on windows<br />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't do a good job of detecting the starting point of the old CHANGELOG, we will be submitting a PR to fix this.

@dcodeIO
Copy link
Member

dcodeIO commented Mar 11, 2020

I for one welcome our new robot overlords. Perhaps it makes sense to give #1356 a look before tagging a 6.9.0?

@bcoe
Copy link
Contributor

bcoe commented Mar 11, 2020

@dcodeIO sounds good, we can hold our horses before we merge this. @alexander-fenster and I were talking about maybe adding a feature where you could add a tag and create a candidate release from this PR, without merging it, so folks could:

npm i protobufjs@next

@bcoe
Copy link
Contributor

bcoe commented Mar 11, 2020

@dcodeIO are you comfortable with this slight change in template template format going forward, we no longer have the #锔忊儯.

It is possible to add new templates to release-please which match your old format more closely, it's a few hours of work mind you (and I'd only do it if this change in formatting drives you up the wall).

@release-please release-please bot reopened this Apr 17, 2020
@alexander-fenster
Copy link
Contributor

alexander-fenster commented Apr 17, 2020

I have just released 6.9.0-pre as next from this branch to run some integration tests on our side. Looks good so far, I think we can proceed with releasing 6.9.0. @bcoe

@publish-bot
Copy link

publish-bot bot commented Apr 17, 2020

A candidate release, 6.9.0-beta.0 was published to npm. Run npm install protobufjs@next to install.

@bcoe bcoe removed the blocked label Apr 17, 2020
@alexander-fenster
Copy link
Contributor

We ran all kinds of integration tests and we're pretty sure it's safe to release it, but let's still do it on Monday and not on Friday :) As soon as this PR is merged, the robot will do its job and we'll officially declare auto-publishing working.

@bcoe bcoe deleted the release-v6.9.0 branch April 20, 2020 21:44
taylorcode pushed a commit to taylorcode/protobuf.js that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants