Add checkbox to clear all Variables
#666
Conversation
|
Great change! I think my preference here would be to create a dialog that allows for selection of columns, in order to not clutter the top space with many options. What do you think? |
|
@typpo I hadn't thought of a dialogue, but that sounds like a good idea. I'll give it a try. |
sangwoo-joh
force-pushed
the
clear-all-variables
branch
from
d11140d
to
49be9ac
Compare
|
Dear @typpo, I replaced the |
|
I tried to upload some working images and gifs, but they won't upload due to Github's issue... |
| <Checkbox checked={selectedColumns.indexOf(column.value) > -1} /> | ||
| <ListItemText primary={column.label} /> |
There was a problem hiding this comment.
I'm noticing that clicking the checkbox should update the state (right now, you can't actually toggle the checkbox). Let's also connect the label with the checkbox, so that clicking it toggles the state too
There was a problem hiding this comment.
Yes, I've noticed too. I'm trying to fix this now. Thank you!
There was a problem hiding this comment.
@typpo I've restored the original functionality of the checkbox.
Please let me know if I have additional corrections.
Thank you!
sangwoo-joh
force-pushed
the
clear-all-variables
branch
from
4551f63
to
efa752b
Compare
|
I rebased these commits to the |
This fix is a suggestion that addresses a perhaps personal inconvenience for me. If you have a better solution, I'd love to hear it and hope you'll consider this positively.
The CSV file I use for testing has a lot of columns, not all of which are actually used in the prompt template, but all of which appear as
Variablein the viewer. This makes it difficult to keep only the columns I want inSelect.This fix adds a checkbox to either deselect all the
Variables at once or select them all. I couldn't figure out the right place for it, so I put it in the sameBoxas the columnSelectfor now, but if you have a better place, please let me know.Thanks for the great open source. I always appreciate it!