Add option for export metric timestamps #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! This seems reasonable, since the drift is limited by the expiry time. Could you please add the sign-off (see the failed check) and document this option in the README, especially when someone would (not) want to use it? |
so it can be published. Fixup for #35. Signed-off-by: Matthias Rampke <mr@soundcloud.com> Signed-off-by: Pavel Boev <pavel.boev@iqoption.com>
Signed-off-by: Pavel Boev <pavel.boev@iqoption.com>
Signed-off-by: Pavel Boev <pavel.boev@iqoption.com>
|
@matthiasr Okay, I did it. |
Signed-off-by: Pavel Boev <pavel.boev@iqoption.com>
matthiasr
approved these changes
Feb 15, 2019
There was a problem hiding this comment.
Thanks a ton! I want to add another note on the effects this has server-side, but that's not compatible with DCO so I'll do it on master.
matthiasr
pushed a commit
that referenced
this pull request
Feb 15, 2019
trying to explain the server-side semantics of this change. Signed-off-by: Matthias Rampke <mr@soundcloud.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
This PR will add support for set timestamp to metrics by add flag
--timestamps.This now possible by #187