Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return type on get envelope::getHeader too strict #112

Merged
merged 3 commits into from Sep 22, 2023
Merged

return type on get envelope::getHeader too strict #112

merged 3 commits into from Sep 22, 2023

Conversation

basz
Copy link
Collaborator

@basz basz commented Sep 22, 2023

No description provided.

@basz basz mentioned this pull request Sep 22, 2023
Closed
@basz basz changed the title add failing test return type on get envelope::getHeader too strict Sep 22, 2023
@basz basz requested a review from prolic September 22, 2023 10:53
prolic
prolic approved these changes Sep 22, 2023
View reviewed changes
Copy link
Owner

@prolic prolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@basz basz merged commit 888095a into prolic:master Sep 22, 2023
16 checks passed
@basz basz deleted the typehint-on-header branch September 22, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prolic prolic prolic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basz @prolic