Skip to content

Commit

Permalink
feat(jsii): new jsii projects default to 5.4.x (#3558)
Browse files Browse the repository at this point in the history
The jsii 5.0 version line is no longer supported.

Fixes #3555 

---
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • Loading branch information
mrgrain committed May 6, 2024
1 parent e62752b commit 5cf621a
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion src/cdk/jsii-project.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export interface JsiiProjectOptions extends TypeScriptProjectOptions {
* (e.g. `~5.0.0`).
*
* @default "1.x"
* @pjnew "~5.0.0"
* @pjnew "~5.4.0"
*/
readonly jsiiVersion?: string;
}
Expand Down
8 changes: 4 additions & 4 deletions test/__snapshots__/inventory.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions test/__snapshots__/new.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions test/inventory.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,11 @@ describe("all default values in docstrings are renderable JS values", () => {
});

test("@pjnew is parsed as initial value", () => {
const jsiiVersionOption = result
.find((p) => p.pjid === "jsii")
?.options.find((o) => o.name === "jsiiVersion");
const option = result
.find((p) => p.pjid === "typescript")
?.options.find((o) => o.name === "projenrcTs");

expect(jsiiVersionOption?.initialValue).toBe('"~5.0.0"');
expect(option?.initialValue).toBe("true");
});

test("all allowed default values can be discovered and rendered", () => {
Expand Down

0 comments on commit 5cf621a

Please sign in to comment.