Makes Stripe integration optional #182
Conversation
|
@michaelwschultz is attempting to deploy a commit to the Salgsmaskin Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Not sure it's the best way commenting the Stripe part. Maybe can be more elegant adding an env var that can specifies if you are self hosting or not the project. I mean, it can be a boolean something like "SELF_HOST:true|false" and inside the code in each points where we are using Stripe we can wrap them by checking if this env var is true or false. If it's true Stripe logic will be avoided otherwise it will be enabled and triggered.
|
I guess I'm curious if Stripe is even needed at this point. Is there a product write up anywhere that talks about what is needed for MVP? |
|
@michaelwschultz I dont think stripe is needed at this point. We should just remove the dependency for it for now (just my thought) |
We only need Stripe in hosted version. So we can avoid it as I wrote days ago, via an env var. |
Description
Stripe seems like it isn't necessary right now and in fact something that is a deterrent for local development. For now, I commented out the place it's used so it can be brought back easily. Not sure that commented code follows the current guidelines. If so, happy to remove it altogether.
I also left the env variables in the
.env.examplebut made it clear they are optional. They are still required by the type checker, but since there are defaults, I thought this would be fine. This makes commenting out the code simple as well since there isn't a bunch of stuff that needs to be removed in order to satisfy the removal of the env variables.What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes: #112
Mobile & Desktop Screenshots/Recordings
Steps to QA
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?