Fix double "x" in close preview modal button #1312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The close modal button currently has two 'X's on top of each other. Bootstrap provides the X as a properly sized SVG via the CSS background property so the 'x' within the HTML <button> is not needed.
raduhazsda
approved these changes
Apr 8, 2024
raduhazsda
reviewed
Apr 8, 2024
| @@ -10,7 +10,7 @@ | |||
| <div class="modal-content"> | |||
| <div class="modal-header"> | |||
| <h5 class="modal-title"></h5> | |||
| <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close">×</button> | |||
| <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> | |||
There was a problem hiding this comment.
Tried on my projectsand as well and it does work the same way.
There was a problem hiding this comment.
For some reason didn't help me. I mean, if I remove "x" via inspect - it works, but editing file_preview_modal.js still gives me the "x" in the page code. Tried to clear the cache/different browser without any luck.
There was a problem hiding this comment.
Did you rebuild the project with gulp or gulp prod?
There was a problem hiding this comment.
Yes, otherwise you won't see changes made to file_preview_modal.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this great project!
The close button on the preview modal currently has two
X's on top of each other. Bootstrap 5 modals provide theXas a properly sized SVG via the CSSbackgroundproperty so the'x'text within the HTML<button>is not needed.Before:
After:
I did a search in this repo's issues and found that this was reported once in #1225 but there is also an unrelated issue reported in that one so I didn't want to automatically close it with this PR. At least mentioning it here will link this PR to that issue.