Graceful handling of image filetypes not supported by SimpleImage #1049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1048
Currently, if a file returns TRUE for isImage() (which checks vs mimetype), but isn't supported by SimpleImage, we get a broken link
.
SimpleImage supports "gif", "jpg", "jpeg", "png", "webp", and "bmp" formats (also "jfif" which is just another jpg variant). We also have a way to handle svg file previews.
As such, I am validating whether an image is embeddable vs these extensions, and I've changed the structure of the preview generation in
manage-files.php
andtemplate.php
to generate the graceful/thumbnail-unavailable.png
Alternatively, we could keep isImage filtering by mimetype and then have an exception from SimpleImage's failure to generate a thumbnail trigger
thumbnail-unavailable
. This is probably the cleaner way but I don't have time :)