You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, no file appears inside /upload/thumbnails.
It sounds like tifs are compatible but something is broken. If they aren't, we should probably just have no preview. Also, I'm not sure what handles the thumbnail generation but I think it should recognize when an expected file hasn't been generated and fail into no preview.
The text was updated successfully, but these errors were encountered:
I had some time so I poked around for the thumbnail generator. The function isImage is correctly identifying TIF as an image but claviska/simpleimage doesn't appear to support TIF files.
I see that in setEmbeddableType you are relying on isImage() to give files the greenlight, so any image format that isn't supported by simpleimage is waved through. On my branch I changed it to
However, this didn't stop the broken URLs from being generated and appearing, so something else must be up. It seems that sometimes we check for $file->embeddable and sometimes we don't. I tried poking at it and shattered everything so I'm gonna back off for now. I might take another look when I have some time.
ehawman-rosenberg
changed the title
tif Files Not Generating Thumbnails
Unsupported image files fail to generate thumbnails (tif)
Dec 16, 2021
Just tested on r1335. Uploaded a tif, assigned it to a test client, looked at the "View my files" page and the preview looks like this
Inspecting the source shows that a URL is being generated
<img src="https://rosenberg-library.org/filesend/upload/thumbnails/thumb_a28ffc586d2a871842a4af62ea4959ed_50x50.tif" class="thumbnail" alt="Test Tif .tif">
However, no file appears inside
/upload/thumbnails
.It sounds like tifs are compatible but something is broken. If they aren't, we should probably just have no preview. Also, I'm not sure what handles the thumbnail generation but I think it should recognize when an expected file hasn't been generated and fail into no preview.
The text was updated successfully, but these errors were encountered: